-
-
Notifications
You must be signed in to change notification settings - Fork 612
Confine contact addresses to the WFE #8245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aren't we sending them to the email exporter? It would be nice to retain the validation we have, and continue failing registration and not sending them to the exporter. |
That's a good point; I was forgetting that we only send contacts to email-exporter after account creation has succeeded, and that therefore we were implicitly still validating the addresses before exporting them. I've hoisted this validation into the WFE directly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the change looks great. I especially like that you moved the validation up near the top of NewAccount.
@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
This integration test was removed in the early versions of #8245, because that PR had removed all validation of contact addresses. However, later iterations of that PR restored (most) contact validation, so this PR restores (most of) the TestAccountEmailError integration test.
Change the WFE to stop populating the Contact field of the NewRegistration requests it sends to the RA. Similarly change the WFE to ignore the Contact field of any update-account requests it receives, thereby removing all calls to the RA's UpdateRegistrationContact method.
Hoist the RA's contact validation logic into the WFE, so that we can still return errors to clients which are presenting grossly malformed contact fields, and have a first layer of protection against trying to send malformed addresses to email-exporter.
A follow-up change (after a deploy cycle) will remove the deprecated RA and SA methods.
Part of #8199