fix(metrics-opentelemetry): isXXX function aren't correct #2918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
achingbrain
added a commit
that referenced
this pull request
Jan 27, 2025
Functions like this are used in several places in the stack so move them to the utils package for reuse. Incorporates changes from #2918
achingbrain
added a commit
that referenced
this pull request
Jan 27, 2025
Functions like this are used in several places in the stack so move them to the utils package for reuse. Incorporates changes from #2918
achingbrain
added a commit
that referenced
this pull request
Jan 27, 2025
Functions like this are used in several places in the stack so move them to the utils package for reuse. Incorporates changes from #2918
3 tasks
achingbrain
added a commit
that referenced
this pull request
Jan 27, 2025
Functions like this are used in several places in the stack so move them to the utils package for reuse. Incorporates changes from #2918
3 tasks
achingbrain
added a commit
that referenced
this pull request
Feb 3, 2025
Includes improvements to detection from #2918 --------- Signed-off-by: Sacha Froment <[email protected]> Co-authored-by: Sacha Froment <[email protected]>
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sacha Froment [email protected]
Title
Description
Notes & open questions
Change checklist