Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use isPromise/etc function from utils #2925

Merged
merged 5 commits into from
Feb 3, 2025
Merged

fix: use isPromise/etc function from utils #2925

merged 5 commits into from
Feb 3, 2025

Conversation

achingbrain
Copy link
Member

Includes improvements to detection from #2918

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner January 27, 2025 14:23
@achingbrain achingbrain changed the title fix(metrics-opentelemetry): isXXX function aren't correct fix: use isPromise/etc function from utils Jan 27, 2025
@achingbrain achingbrain merged commit a32fbeb into main Feb 3, 2025
32 checks passed
@achingbrain achingbrain deleted the sfroment-main branch February 3, 2025 11:05
This was referenced Feb 3, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @sfroment