feat: Configure maxDataLength for it-length-prefixed in PeerStreams #2954
+88
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eerStreams Options
acul71
changed the title
|
answer: modify it everywhere |
|
@achingbrain @SgtPooki let me know |
|
Is the interop CI failure due to these changes or do we have a flaky test? |
SgtPooki
reviewed
Feb 11, 2025
Co-authored-by: Russell Dempsey <[email protected]>
Co-authored-by: Russell Dempsey <[email protected]>
Co-authored-by: Russell Dempsey <[email protected]>
Co-authored-by: Russell Dempsey <[email protected]>
|
@SgtPooki @achingbrain @dhuseby Update |
achingbrain
reviewed
Feb 13, 2025
| import { pipe } from 'it-pipe' | ||
| import { pushable } from 'it-pushable' | ||
| import { Uint8ArrayList } from 'uint8arraylist' | ||
| import type { ComponentLogger, Logger, Stream, PeerId, PeerStreamEvents } from '@libp2p/interface' | ||
| import type { Pushable } from 'it-pushable' | ||
| // import { type DecoderOptions as LpDecoderOptions } from 'it-length-prefixed' // Enable this when DecoderOptions will be exported from it-length-prefixed |
There was a problem hiding this comment.
These types are exported as of [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Allow configuration of it-length-prefixed maxDataLength via PeerStreams Options
Description
This PR introduces a new feature that allows users to configure the
maxDataLengthoption used byit-length-prefixedthrough thePeerStreamsoptions. Previously, the library defaulted to a maximum data length of 4MB, which could lead to issues when processing larger messages. With this change, both the encoder and decoder init-length-prefixedcan be configured to use a custommaxDataLength(e.g., 8MB), thus accommodating larger messages.In addition, I have upgraded
it-length-prefixedto version10.0.0inpackages/pubsub/package.json. However, I'm not sure if this is the only place where the upgrade is required. A review of other packages that depend onit-length-prefixedmight be necessary.A new test has been added to validate the behavior, ensuring that a 6MB message is correctly transmitted and received without triggering an error, and that the content of the sent and received messages are identical.
Notes & open questions
[email protected]inpackages/pubsub/package.jsonhas been performed, but please verify if additional changes are needed in other parts of the repository.Change checklist