factor out parts of IMG_LoadJPG where locals can be clobbered by longjmp (SDL3 version) #545
+101
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcv
reviewed
Apr 9, 2025
|
PING @slouken |
|
@smcv : Is this OK with you? (Also its SDL2 counterpart.) The error message stuff you noted requires another go at the full source tree, as far as I can see. |
|
Well, I did went ahead and sanitized error setting a bit for png and jpg loaders, both here and in the SDL2 version as well. Please review. |
sezero
force-pushed
the
jpg-longjmp3
branch
2 times, most recently
from
2066be8 to
f4ac1e5
Compare
Also sanitize error setting a bit in IMG_LoadPNG() Fixes libsdl-org#435
|
This is in now. If there are any issues, please open a new ticket for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #435
CC: @smcv