Fix text width handling in inspector #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pecoram
commented
Dec 5, 2025
pecoram
commented
- Adjust the width and height properties to return 'auto' instead of '1px' for zero values.
- Update the inspector's text handling to use visibility instead of color for inspector text visible during color transitions.
wouterlucas
reviewed
Dec 15, 2025
| export type { Inspector } from '../src/main-api/Inspector.js'; | ||
| export type { CoreNodeRenderState } from '../src/core/CoreNode.js'; | ||
|
|
||
| export type { CoreRenderer } from '../src/core/renderers/CoreRenderer.js'; |
Contributor
There was a problem hiding this comment.
I don't think we need this export....
| export type { | ||
| AnimationSettings, | ||
| CoreAnimation, | ||
| } from '../src/core/animations/CoreAnimation.js'; |
Contributor
There was a problem hiding this comment.
I don't think we need this export...
| if (h === 0) { | ||
| // Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible | ||
| return { prop: 'height', value: '1px' }; | ||
| return { prop: 'height', value: 'auto' }; |
Contributor
There was a problem hiding this comment.
will auto still ensure its visible? even if it has no width set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.