-
Notifications
You must be signed in to change notification settings - Fork 30
Fix text width handling in inspector #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pecoram
wants to merge
1
commit into
lightning-js:v2
Choose a base branch
from
pecoram:fix/inspector-text-width
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,10 @@ export { | |
| export type { ShaderMap, EffectMap } from '../src/core/CoreShaderManager.js'; | ||
| export type { TextRendererMap } from '../src/core/text-rendering/renderers/TextRenderer.js'; | ||
| export type { TrFontFaceMap } from '../src/core/text-rendering/font-face-types/TrFontFace.js'; | ||
| export type { AnimationSettings } from '../src/core/animations/CoreAnimation.js'; | ||
| export type { | ||
| AnimationSettings, | ||
| CoreAnimation, | ||
| } from '../src/core/animations/CoreAnimation.js'; | ||
| export type { | ||
| EffectProps, | ||
| FadeOutEffectProps, | ||
|
|
@@ -75,6 +78,8 @@ export type { WebGlCoreCtxTexture } from '../src/core/renderers/webgl/WebGlCoreC | |
| export type { Inspector } from '../src/main-api/Inspector.js'; | ||
| export type { CoreNodeRenderState } from '../src/core/CoreNode.js'; | ||
|
|
||
| export type { CoreRenderer } from '../src/core/renderers/CoreRenderer.js'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need this export.... |
||
|
|
||
| // Shaders | ||
| export * from '../src/core/renderers/webgl/WebGlCoreShader.js'; | ||
| export * from '../src/core/renderers/webgl/shaders/effects/ShaderEffect.js'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,16 +52,14 @@ const stylePropertyMap: { | |
| }, | ||
| width: (w) => { | ||
| if (w === 0) { | ||
| // Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible | ||
| return { prop: 'width', value: '1px' }; | ||
| return { prop: 'width', value: 'auto' }; | ||
| } | ||
|
|
||
| return { prop: 'width', value: `${w}px` }; | ||
| }, | ||
| height: (h) => { | ||
| if (h === 0) { | ||
| // Set to 1px instead of 0px so visibility checks (e.g. Playwright) keep treating the node as visible | ||
| return { prop: 'height', value: '1px' }; | ||
| return { prop: 'height', value: 'auto' }; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will auto still ensure its visible? even if it has no width set? |
||
| } | ||
|
|
||
| return { prop: 'height', value: `${h}px` }; | ||
|
|
@@ -577,9 +575,7 @@ export class Inspector { | |
| // special case for text | ||
| if (property === 'text') { | ||
| div.innerHTML = String(value); | ||
|
|
||
| // Keep DOM text invisible without breaking visibility checks by using color:transparent instead of opacity:0 | ||
| div.style.color = 'transparent'; | ||
| div.style.visibility = 'hidden'; | ||
| div.style.pointerEvents = 'none'; | ||
| div.style.userSelect = 'none'; | ||
| return; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this export...