Use BDK events in update_payment_store
#658
Conversation
|
I've assigned @tnull as a reviewer! |
Camillarhi
force-pushed
the
payment-store-events-sync
branch
9 times, most recently
from
75ff700 to
d3f7855
Compare
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 4th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 5th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 6th Reminder Hey @tnull! This PR has been waiting for your review. |
There was a problem hiding this comment.
Excuse the delay here!
Unfortunately I don't think we can make the move until we get corresponding functionality for all chain sources, i.e., also for bitcoind/apply_block. Will raise that with the BDK folks to make some progress.
I now opened bitcoindevkit/bdk_wallet#336 to add the missing APIs we need. In the meantime we can see to get this as close to being mergeable as possible.
src/wallet/mod.rs
Outdated
| })?; | ||
|
|
||
| self.update_payment_store(&mut *locked_wallet).map_err(|e| { | ||
| let events_vec: Vec<WalletEvent> = events.into_iter().collect(); |
There was a problem hiding this comment.
I don't think this re-allocation is necessary?
There was a problem hiding this comment.
Thanks! I have removed the re-allocation
| ); | ||
| } | ||
|
|
||
| match locked_wallet.apply_block(block, height) { |
There was a problem hiding this comment.
Ugh, seems there is no corresponding apply_block_events method. I think we need that before actually moving forward here. Will raise it with the BDK folks.
| } | ||
|
|
||
| self.payment_store | ||
| .list_filter(|p| { |
There was a problem hiding this comment.
Hmm, ugh, that's already slow right now, but will be prohibitively slow when we don't keep our entire payment store in-memory. I think we can't get around adding another persisted lookup table that tracks RBF-Txid to original-Txid.
There was a problem hiding this comment.
Yes, this is true, if we have another table, the lookup will be faster and the original Txid can be updated when the RBF-Txid for example, has a confirmed event from BDK
…sactions Replace the full transaction list scan in `update_payment_store` with handling of BDK's `WalletEvent` stream during sync. This leverages the new events in BDK 2.2, reduces redundant work, and prepares the foundation for reliable RBF/CPFP tracking via `WalletEvent::TxReplaced`.
Camillarhi
force-pushed
the
payment-store-events-sync
branch
from
d3f7855 to
a2c8a55
Compare
3 participants
This PR updates
update_payment_storeto use BDK 2.2’sWalletEventstream during sync instead of iterating over the full list of wallet transactions every time. The new event-based approach reduces redundant work and ensures the payment store stays in sync with only the changes that actually occurred.It also sets up the foundation for RBF support in #628 with
WalletEvent::TxReplaced. Since #628 depends on this event handling, this PR should be merged first.This PR will also address #452