accounts: Credit and debit accounts DB additions prep #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we add the SQLStore type which implements the accounts.Store interface. To demonstrate that it works as expected, we also plug this implementation into all the account unit tests to show that they pass against the sqlite and postgres backends. One can use `make unit pkg=accounts tags=test_db_postgres` or `make unit pkg=accounts tags=test_db_sqlite` to test locally. Note that 2 small timestamp related changes are made to the unit tests. This is to compensate for timestamp precision in postgres.
In preparation for the upcoming credit/debit accounts feature, rename the store `IncreaseAccountBalance` method to `CreditAccount` to better reflect its purpose.
To support decreasing an existing off-chain account’s balance by a specified amount in the database, we'll first implement the functionality in the db stores. This commit introduces the `DebitAccount` function in the kvdb store.
This commit introduces the `DebitAccount` function in the sqlc store, to support decreasing the balance of an existing off-chain account by a specified amount for sql backends. We'll also add testing of the store functionality, as both stores now support the `DebitAccount` operation.
This commit adds a separate `CreditAccount` query to the sql db, to incentivize not setting the balance directly, but rather instead increase and decrease the balance by a specific amount. We also update the sql store to use the new query in the `CreditAccount` method.
ViktorTigerstrom
added
the
no-changelog
This was referenced Feb 11, 2025
ViktorTigerstrom
requested review from
ellemouton
and removed request for
ellemouton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #648
Based on #954
This PR adds DB preparation required in order to support functionality which allows crediting or debiting an account's balance by a given amount, rather than the current update method, which sets the balance to a specific value.