accounts: Add CreditAccount & DebitAccount sql queries
#982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorT-11
added
the
no-changelog
This commit adds a separate `CreditAccount` query to the sql db, to incentivize not setting the balance directly, but rather instead increase and decrease the balance by a specific amount. We also update the sql store to use the new query function, instead of setting the balance directly.
ViktorT-11
force-pushed
the
2025-02-credit-account-sql-query
branch
from
44ae7e0 to
e20bf18
Compare
ViktorT-11
changed the title
CreditAccount sql queryCreditAccount & DebitAccount sql queries
bitromortac
reviewed
Mar 19, 2025
This commit adds a separate `DebitAccount` query to the sql db, to incentivize not setting the balance directly, but rather instead increase and decrease the balance by a specific amount. We also update the sql store to use the new query function, instead of setting the balance directly.
ViktorT-11
force-pushed
the
2025-02-credit-account-sql-query
branch
from
e20bf18 to
46bc3c0
Compare
|
I think I dont quite follow the motivation for this change? in my mind the DB CRUD layer should be just that and then any business logic should be on a code layer above. Having the addition/subtraction on the code layer also allows us to do extra validation etc (more business logic) before performing any DB commits. |
|
@ellemouton: review reminder |
|
We decided offline to not proceed with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces separate
CreditAccountandDebitAccountqueries for the SQL database. The change encourages increasing the balance by a specific amount rather than setting it directly.