Skip to content

Feature/upgrade ogx to 1.2.x - #2396

Closed
tisnik wants to merge 9 commits into
mainfrom
feature/upgrade-ogx-to-1.2.x
Closed

Feature/upgrade ogx to 1.2.x#2396
tisnik wants to merge 9 commits into
mainfrom
feature/upgrade-ogx-to-1.2.x

Conversation

@tisnik

@tisnik tisnik commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Compatibility
    • Updated support for the latest OGX client API version (1.2.2).
    • Improved compatibility with current model, provider, prompt, conversation, and vector-store responses.
  • Bug Fixes
    • Improved prompt retrieval when no version is specified.
    • Improved conversation pagination and handling of invalid conversation items.
    • Improved vector-store and file listing, including error reporting.
    • Improved model metadata parsing across supported providers.
  • Tests
    • Updated automated coverage for the latest API response formats and pagination behavior.

@tisnik tisnik closed this Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ef405c9-f4f5-400d-b80d-cbf09ae6acc2

📥 Commits

Reviewing files that changed from the base of the PR and between 0ef8ccc and d6643bd.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (41)
  • pyproject.toml
  • src/app/endpoints/prompts.py
  • src/app/endpoints/providers.py
  • src/app/endpoints/rags.py
  • src/app/endpoints/vector_stores.py
  • src/constants.py
  • src/utils/builtin_tools.py
  • src/utils/conversation_compaction.py
  • src/utils/conversations.py
  • src/utils/model_list.py
  • src/utils/responses.py
  • tests/e2e/features/info.feature
  • tests/integration/conftest.py
  • tests/integration/endpoints/test_conversations_v1_integration.py
  • tests/integration/endpoints/test_info_integration.py
  • tests/integration/endpoints/test_model_list.py
  • tests/integration/endpoints/test_query_byok_integration.py
  • tests/integration/endpoints/test_query_integration.py
  • tests/integration/endpoints/test_responses_byok_integration.py
  • tests/integration/endpoints/test_responses_integration.py
  • tests/integration/endpoints/test_root_endpoint.py
  • tests/integration/endpoints/test_streaming_query_byok_integration.py
  • tests/integration/endpoints/test_streaming_query_integration.py
  • tests/unit/app/endpoints/test_a2a.py
  • tests/unit/app/endpoints/test_conversations.py
  • tests/unit/app/endpoints/test_info.py
  • tests/unit/app/endpoints/test_models.py
  • tests/unit/app/endpoints/test_prompts.py
  • tests/unit/app/endpoints/test_providers.py
  • tests/unit/app/endpoints/test_rags.py
  • tests/unit/app/endpoints/test_responses.py
  • tests/unit/app/endpoints/test_rlsapi_v1.py
  • tests/unit/app/endpoints/test_vector_stores.py
  • tests/unit/metrics/test_utis.py
  • tests/unit/test_client.py
  • tests/unit/utils/test_builtin_tools.py
  • tests/unit/utils/test_conversations.py
  • tests/unit/utils/test_llama_stack_version.py
  • tests/unit/utils/test_model_list.py
  • tests/unit/utils/test_query.py
  • tests/unit/utils/test_responses.py

Walkthrough

Updated OGX dependencies from 1.0.2 to 1.2.2. Migrated application code and tests to generated client models, direct collection responses, typed conversation requests, and explicit cursor pagination.

Changes

OGX client migration

Layer / File(s) Summary
Endpoint response adapters
pyproject.toml, src/app/endpoints/*, src/constants.py, src/utils/responses.py
Endpoints now use generated provider models, direct vector-store collections, simplified error checks, and the version 1.2.2.
Generated model catalog integration
src/utils/model_list.py, tests/integration/conftest.py, tests/integration/endpoints/test_model_list.py, tests/unit/utils/test_model_list.py
Model parsing and fixtures use generated OpenAI, Anthropic, Google, and union response models.
Typed conversation requests and pagination
src/utils/conversations.py, src/utils/conversation_compaction.py, tests/unit/utils/test_conversations.py
Conversation items are validated into generated models, submitted through AddItemsRequest, and retrieved with cursor pagination.
Client compatibility test mocks
tests/integration/*, tests/unit/*, tests/e2e/features/info.feature
Tests adopt generated import paths, direct collection mocks, iterable test doubles, updated pagination fields, and the new version expectation.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested reviewers: asimurka

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/upgrade-ogx-to-1.2.x
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature/upgrade-ogx-to-1.2.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants