Skip to content

Feature/upgrade ogx to 1.2.x - #2407

Closed
tisnik wants to merge 11 commits into
mainfrom
feature/upgrade-ogx-to-1.2.x
Closed

Feature/upgrade ogx to 1.2.x#2407
tisnik wants to merge 11 commits into
mainfrom
feature/upgrade-ogx-to-1.2.x

Conversation

@tisnik

@tisnik tisnik commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • New Features

    • Improved compatibility with updated model, provider, prompt, conversation, and vector store APIs.
    • Enhanced provider configuration handling, including Azure token updates.
    • Added support for richer vector store file attributes and more reliable model discovery.
  • Bug Fixes

    • Fixed handling of missing vector store names and error details.
    • Improved conversation pagination and item processing.
    • Updated supported Llama Stack version compatibility.

@tisnik tisnik closed this Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 61585ca8-aa6a-47ef-af21-82f948872f57

📥 Commits

Reviewing files that changed from the base of the PR and between f32e625 and 13361d1.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (51)
  • pyproject.toml
  • src/app/endpoints/models.py
  • src/app/endpoints/prompts.py
  • src/app/endpoints/providers.py
  • src/app/endpoints/rags.py
  • src/app/endpoints/rlsapi_v1.py
  • src/app/endpoints/vector_stores.py
  • src/client.py
  • src/constants.py
  • src/metrics/utils.py
  • src/models/api/responses/successful/vector_stores.py
  • src/pydantic_ai_lightspeed/llamastack/_provider.py
  • src/utils/builtin_tools.py
  • src/utils/conversation_compaction.py
  • src/utils/conversations.py
  • src/utils/model_list.py
  • src/utils/responses.py
  • src/utils/types.py
  • tests/e2e/features/info.feature
  • tests/integration/conftest.py
  • tests/integration/endpoints/test_conversations_v1_integration.py
  • tests/integration/endpoints/test_info_integration.py
  • tests/integration/endpoints/test_model_list.py
  • tests/integration/endpoints/test_query_byok_integration.py
  • tests/integration/endpoints/test_query_integration.py
  • tests/integration/endpoints/test_responses_byok_integration.py
  • tests/integration/endpoints/test_responses_integration.py
  • tests/integration/endpoints/test_root_endpoint.py
  • tests/integration/endpoints/test_streaming_query_byok_integration.py
  • tests/integration/endpoints/test_streaming_query_integration.py
  • tests/unit/app/endpoints/test_a2a.py
  • tests/unit/app/endpoints/test_conversations.py
  • tests/unit/app/endpoints/test_info.py
  • tests/unit/app/endpoints/test_models.py
  • tests/unit/app/endpoints/test_prompts.py
  • tests/unit/app/endpoints/test_providers.py
  • tests/unit/app/endpoints/test_rags.py
  • tests/unit/app/endpoints/test_responses.py
  • tests/unit/app/endpoints/test_rlsapi_v1.py
  • tests/unit/app/endpoints/test_vector_stores.py
  • tests/unit/conftest.py
  • tests/unit/metrics/test_utis.py
  • tests/unit/pydantic_ai_lightspeed/llamastack/test_provider.py
  • tests/unit/test_client.py
  • tests/unit/utils/test_builtin_tools.py
  • tests/unit/utils/test_conversations.py
  • tests/unit/utils/test_llama_stack_version.py
  • tests/unit/utils/test_model_list.py
  • tests/unit/utils/test_pydantic_ai.py
  • tests/unit/utils/test_query.py
  • tests/unit/utils/test_responses.py

Walkthrough

The pull request upgrades OGX packages to 1.3.0 and migrates model, provider, vector-store, and conversation integrations to updated generated client APIs. Tests and fixtures now use the new response shapes, collection behavior, and pagination fields.

Changes

OGX API migration

Layer / File(s) Summary
API contracts and endpoint migration
pyproject.toml, src/app/endpoints/*, src/utils/*, src/models/..., src/constants.py
Updated OGX dependencies, model listing, vector-store collections, provider types, response mappings, generated model parsing, and singleton typing.
Client provider-data lifecycle
src/client.py, src/pydantic_ai_lightspeed/llamastack/_provider.py
Added provider-data reading and preserved provider data while rebuilding Azure library and service clients.
Conversation model and pagination migration
src/utils/conversations.py, src/utils/conversation_compaction.py
Migrated conversation handling to typed OGX models, typed add-item requests, and explicit cursor pagination.
Shared test fixtures and endpoint migration
tests/integration/*, tests/unit/*, tests/e2e/*
Updated model, vector-store, provider, version, API-client, and endpoint tests for the new OGX interfaces.
Conversation validation and pagination tests
tests/unit/utils/test_conversations.py
Added typed item parsing and request-building coverage and updated pagination assertions for has_more, last_id, and after.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested reviewers: asimurka

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/upgrade-ogx-to-1.2.x
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature/upgrade-ogx-to-1.2.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants