Implement Links trait for Doublets instead of trait inheritance #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
This PR implements the solution for issue #6 by reversing the trait relationship between
Links
andDoublets
traits.📋 Issue Reference
Fixes #6
🔄 Changes Made
1. Trait Hierarchy Refactoring
pub trait Doublets<T: LinkType>: Links<T>
pub trait Doublets<T: LinkType>: Send + Sync
2. Core Methods Integration
Moved all core
Links
trait methods into theDoublets
trait:constants(&self) -> &LinksConstants<T>
count_links(&self, query: &[T]) -> T
create_links(...)
,each_links(...)
,update_links(...)
,delete_links(...)
get_link(&self, index: T) -> Option<Link<T>>
3. Blanket Implementation
Added automatic
Links
implementation for any type implementingDoublets
:4. Store Implementation Update
Links<T>
andDoublets<T>
forStore
Doublets<T>
, automatically getsLinks<T>
via blanket impl🎉 Benefits
data-rs
repositoryimpl Links for Doublets
instead ofDoublets for Links
Links
implementation for allDoublets
types🧪 Testing
The implementation maintains full API compatibility. All existing code using either
Links
orDoublets
traits will continue to work without changes.🔗 Related
🤖 Generated with Claude Code