Skip to content

Implement Links trait for Doublets instead of trait inheritance #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement Links trait for Doublets instead of trait inheritance #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6283251
Initial commit with task details for issue #6
konard Sep 11, 2025
ebaec21
Remove CLAUDE.md - PR created successfully
konard Sep 11, 2025
0333a51
Implement Links trait for Doublets instead of trait inheritance
konard Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 52 additions & 3 deletions doublets/src/data/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use bumpalo::Bump;

Check warning on line 1 in doublets/src/data/traits.rs

View workflow job for this annotation

GitHub Actions / Benchmark 

unused import: `bumpalo::Bump`
#[cfg(feature = "rayon")]
use rayon::prelude::*;
use std::{
Expand Down Expand Up @@ -34,7 +34,27 @@
-> Result<Flow, Error<T>>;
}

pub trait Doublets<T: LinkType>: Links<T> {
pub trait Doublets<T: LinkType>: Send + Sync {
fn constants(&self) -> &LinksConstants<T>;

fn count_links(&self, query: &[T]) -> T;

fn create_links(&mut self, query: &[T], handler: WriteHandler<'_, T>)
-> Result<Flow, Error<T>>;

fn each_links(&self, query: &[T], handler: ReadHandler<'_, T>) -> Flow;

fn update_links(
&mut self,
query: &[T],
change: &[T],
handler: WriteHandler<'_, T>,
) -> Result<Flow, Error<T>>;

fn delete_links(&mut self, query: &[T], handler: WriteHandler<'_, T>)
-> Result<Flow, Error<T>>;

fn get_link(&self, index: T) -> Option<Link<T>>;
fn count_by(&self, query: impl ToQuery<T>) -> T
where
Self: Sized,
Expand Down Expand Up @@ -253,8 +273,6 @@
self.get_link(index).ok_or(Error::NotExists(index))
}

fn get_link(&self, index: T) -> Option<Link<T>>;

fn delete_all(&mut self) -> Result<(), Error<T>>
where
Self: Sized,
Expand Down Expand Up @@ -551,7 +569,38 @@
}
}

impl<T: LinkType, D: Doublets<T> + ?Sized> Links<T> for D {
fn constants(&self) -> &LinksConstants<T> {
self.constants()
}

fn count_links(&self, query: &[T]) -> T {
self.count_links(query)
}

fn create_links(&mut self, query: &[T], handler: WriteHandler<'_, T>) -> Result<Flow, Error<T>> {
self.create_links(query, handler)
}

fn each_links(&self, query: &[T], handler: ReadHandler<'_, T>) -> Flow {
self.each_links(query, handler)
}

fn update_links(
&mut self,
query: &[T],
change: &[T],
handler: WriteHandler<'_, T>,
) -> Result<Flow, Error<T>> {
self.update_links(query, change, handler)
}

fn delete_links(&mut self, query: &[T], handler: WriteHandler<'_, T>) -> Result<Flow, Error<T>> {
self.delete_links(query, handler)
}
}

impl<T: LinkType, All: Doublets<T> + ?Sized> Links<T> for Box<All> {

Check failure on line 603 in doublets/src/data/traits.rs

View workflow job for this annotation

GitHub Actions / Benchmark 

conflicting implementations of trait `data::traits::Links<_>` for type `std::boxed::Box<_>`
fn constants(&self) -> &LinksConstants<T> {
(**self).constants()
}
Expand Down
6 changes: 1 addition & 5 deletions doublets/src/mem/unit/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ impl<T: LinkType, M: RawMem<LinkPart<T>>, TS: UnitTree<T>, TT: UnitTree<T>, TU:
}

impl<T: LinkType, M: RawMem<LinkPart<T>>, TS: UnitTree<T>, TT: UnitTree<T>, TU: UnitList<T>>
Links<T> for Store<T, M, TS, TT, TU>
Doublets<T> for Store<T, M, TS, TT, TU>
{
fn constants(&self) -> &LinksConstants<T> {
&self.constants
Expand Down Expand Up @@ -552,11 +552,7 @@ impl<T: LinkType, M: RawMem<LinkPart<T>>, TS: UnitTree<T>, TT: UnitTree<T>, TU:

Ok(handler(link, Link::nothing()))
}
}

impl<T: LinkType, M: RawMem<LinkPart<T>>, TS: UnitTree<T>, TT: UnitTree<T>, TU: UnitList<T>>
Doublets<T> for Store<T, M, TS, TT, TU>
{
fn get_link(&self, index: T) -> Option<Link<T>> {
if self.exists(index) {
// SAFETY: links is exists
Expand Down
Loading