fix: fix wrong display render issue when switching VT too quickly #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @apr3vau. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideImplements explicit render control via the treeland-ddm-v1 protocol by disabling global rendering before VT release and re-enabling it after VT acquisition, preventing incorrect display output when switching virtual terminals too quickly. Sequence diagram for VT switching with explicit render controlsequenceDiagram
participant DaemonApp
participant TreelandConnector
participant TreelandDDM
participant VT
DaemonApp->>TreelandConnector: onReleaseDisplay()
TreelandConnector->>TreelandConnector: disableRender()
TreelandConnector->>TreelandDDM: treeland_ddm_disable_render()
TreelandConnector->>VT: VT_RELDISP ioctl
DaemonApp->>TreelandConnector: onAcquireDisplay()
TreelandConnector->>TreelandConnector: enableRender()
TreelandConnector->>TreelandDDM: treeland_ddm_enable_render()
TreelandConnector->>VT: Activate session
Class diagram for updated TreelandConnector render control methodsclassDiagram
class TreelandConnector {
+void switchToUser(QString username)
+void activateSession()
+void deactivateSession()
+void enableRender()
+void disableRender()
-wl_display *m_display
-QSocketNotifier *m_notifier
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/daemon/TreelandConnector.cpp:196` </location>
<code_context>
+ treeland_ddm_enable_render(m_ddm);
+ wl_display_flush(m_display);
+ } else {
+ qWarning("Treeland is not connected when trying to call enableRender");
+ }
+}
</code_context>
<issue_to_address>
Warning message could include context for easier debugging.
Consider adding relevant details, like session state or user info, to the warning to aid in diagnosing connection problems.
Suggested implementation:
```cpp
} else {
QString sessionState = getSessionState(); // Replace with actual session state retrieval
QString userInfo = getCurrentUserInfo(); // Replace with actual user info retrieval
qWarning("Treeland is not connected when trying to call enableRender. Session state: %s, User info: %s",
qPrintable(sessionState), qPrintable(userInfo));
}
}
```
You will need to implement or use existing functions for `getSessionState()` and `getCurrentUserInfo()` to retrieve the session state and user information. If these functions do not exist, you should add them or replace them with the appropriate code to fetch the required context.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Since switching VT will not drop DRM FD, treeland still able to draw to DRM after VT switched, which will cause wrong display render when switching VT too quickly. This commit use new treeland-ddm-v1 protocol to disable treeland global rendering before VT switching, and enable it after switching complete, thus the issue will be fixed.
zccrs
approved these changes
Aug 21, 2025
zccrs
approved these changes
Aug 21, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apr3vau, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since switching VT will not drop DRM FD, treeland still able to draw to DRM after VT switched, which will cause wrong display render when switching VT too quickly. This commit use new treeland-ddm-v1 protocol to disable treeland global rendering before VT switching, and enable it after switching complete, thus the issue will be fixed.
Summary by Sourcery
Disable Treeland rendering around virtual terminal switches to prevent incorrect DRM output when switching VTs rapidly.
Bug Fixes:
Enhancements: