Skip to content

sync: from linuxdeepin/dtkdeclarative #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Mar 11, 2025
Merged

sync: from linuxdeepin/dtkdeclarative #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/private/dbackdropnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,10 +668,13 @@ class Q_DECL_HIDDEN RhiNode : public DBackdropNode {
}

RenderingFlags flags() const override {
// FIXME: shoule we support DepthAwareRendering?
Copy link

@sourcery-ai sourcery-ai bot Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Correct typo in FIXME comment.

The comment currently uses 'shoule' instead of 'should'. Fixing this typo will improve clarity.

Suggested change
// FIXME: shoule we support DepthAwareRendering?
// FIXME: should we support DepthAwareRendering?

// When enable DepthAwareRendering, render buffer node may have a wrong order.
// Disable DepthAwareRendering here.
if (Q_UNLIKELY(!contentNode))
return BoundedRectRendering | DepthAwareRendering;
return BoundedRectRendering;

return DepthAwareRendering;
return {};
}

void releaseResources() override {
Expand Down