-
Notifications
You must be signed in to change notification settings - Fork 42
fix: wrong z order of render buffer blitter #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Disable DepthAwareRendering to ensure the uniform render order as element order.
Reviewer's Guide by SourceryThis pull request disables Updated class diagram for RhiNodeclassDiagram
class RhiNode {
-RenderingFlags flags()
}
RhiNode : -DepthAwareRendering
RhiNode : +BoundedRectRendering
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#475
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a test case that specifically targets the rendering order issue you're addressing.
- The FIXME suggests uncertainty about DepthAwareRendering; clarify whether it should be re-enabled in the future or removed entirely.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } | ||
|
|
||
| RenderingFlags flags() const override { | ||
| // FIXME: shoule we support DepthAwareRendering? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Correct typo in FIXME comment.
There's a typo in the comment ('shoule' should be 'should'). Although it's a minor issue, updating this will help clarity.
| // FIXME: shoule we support DepthAwareRendering? | |
| // FIXME: should we support DepthAwareRendering? |
|
/approve |
|
/approve cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#475
Disable DepthAwareRendering to ensure the uniform render order as
element order.
Summary by Sourcery
Bug Fixes: