-
Notifications
You must be signed in to change notification settings - Fork 42
fix: hide arrow buttons at list boundaries #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed arrow button visibility logic in ArrowListView to properly hide buttons when reaching the beginning or end of the list. Previously, arrow buttons were only hidden when the list was non-interactive, but remained visible even when at the boundaries of scrollable content. The changes add boundary checks to the visibility conditions: - Up arrow button now hides when at the beginning of the list (atYBeginning) - Down arrow button now hides when at the end of the list (atYEnd) This provides better visual feedback to users and prevents unnecessary button display when no further scrolling is possible. Log: Fixed arrow button visibility in lists to hide when reaching boundaries Influence: 1. Test scrolling through lists with varying content lengths 2. Verify up arrow hides when reaching the top of the list 3. Verify down arrow hides when reaching the bottom of the list 4. Test with both interactive and non-interactive lists 5. Verify button visibility during scroll animations 6. Test edge cases with very short lists fix: 修复列表边界箭头按钮显示问题 修复了ArrowListView中箭头按钮的可见性逻辑,使其在到达列表边界时正确隐藏 按钮。之前箭头按钮仅在列表不可交互时隐藏,但在可滚动内容边界处仍然显示。 修改为可见性条件添加了边界检查: - 向上箭头按钮在到达列表开头时隐藏(atYBeginning) - 向下箭头按钮在到达列表末尾时隐藏(atYEnd) 这为用户提供了更好的视觉反馈,并在无法进一步滚动时避免不必要的按钮显示。 Log: 修复列表边界处箭头按钮的显示问题 Influence: 1. 测试不同长度列表的滚动功能 2. 验证到达列表顶部时向上箭头是否隐藏 3. 验证到达列表底部时向下箭头是否隐藏 4. 测试交互式和非交互式列表的情况 5. 验证滚动动画期间的按钮可见性 6. 测试极短列表的边缘情况 PMS: BUG-278697
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#526
deepin pr auto review我来审查这段代码的修改。 修改概述这段代码修改了两个ArrowListViewButton的可见性条件:
代码分析这个修改的目的是优化ArrowListView的交互体验,通过添加额外的条件来判断列表是否已经滚动到顶部或底部,从而决定是否显示相应的滚动按钮。 改进意见
总结这个修改是一个合理的改进,它优化了用户界面,使其更加直观和易用。虽然有一些小的改进空间,但整体而言,这个修改是有益的,应该保留。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated ArrowListView to hide navigation arrows at the start and end of the list by adding boundary checks to the visibility logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#526
Fixed arrow button visibility logic in ArrowListView to properly hide
buttons when reaching the beginning or end of the list. Previously,
arrow buttons were only hidden when the list was non-interactive, but
remained visible even when at the boundaries of scrollable content.
The changes add boundary checks to the visibility conditions:
(atYBeginning)
This provides better visual feedback to users and prevents unnecessary
button display when no further scrolling is possible.
Log: Fixed arrow button visibility in lists to hide when reaching
boundaries
Influence:
fix: 修复列表边界箭头按钮显示问题
修复了ArrowListView中箭头按钮的可见性逻辑,使其在到达列表边界时正确隐藏
按钮。之前箭头按钮仅在列表不可交互时隐藏,但在可滚动内容边界处仍然显示。
修改为可见性条件添加了边界检查:
这为用户提供了更好的视觉反馈,并在无法进一步滚动时避免不必要的按钮显示。
Log: 修复列表边界处箭头按钮的显示问题
Influence:
PMS: BUG-278697
Summary by Sourcery
Add boundary checks to ArrowListView to hide navigation arrows when the list is at its start or end to prevent unnecessary button display.
Bug Fixes: