Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Oct 23, 2025

as title.

Summary by Sourcery

Refactor the ScrollView QML component to replace the QtQuick.Controls 2.4 version with QtQuick.Templates.ScrollView and custom Deepin scrollbars for Qt5 compatibility

Enhancements:

  • Replace import of QtQuick.Controls with QtQuick.Templates.ScrollView and DTK scrollbars
  • Add implicit size calculations to the ScrollView template
  • Embed custom vertical and horizontal D.ScrollBar components within the template-based ScrollView

@18202781743 18202781743 requested review from BLumia and mhduiy October 23, 2025 07:33
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Oct 23, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#543
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 23, 2025

Reviewer's Guide

Refactors ScrollView.qml to switch from QtQuick.Controls 2.4 to Deepin template-based T.ScrollView and custom D.ScrollBar implementations, adding explicit size calculations and integrating Deepin scrollbars for both vertical and horizontal scrolling.

Class diagram for updated ScrollView.qml structure

classDiagram
class T.ScrollView {
  +implicitWidth
  +implicitHeight
}
class D.ScrollBar {
  +vertical
  +horizontal
  +active
}
T.ScrollView "1" o-- "1" D.ScrollBar : vertical
T.ScrollView "1" o-- "1" D.ScrollBar : horizontal
Loading

File-Level Changes

Change Details Files
Update module imports and component usage
  • Replaced QtQuick.Controls 2.4 import with QtQuick 2.12, QtQuick.Controls.impl, QtQuick.Templates alias, and Deepin DTK modules
  • Changed ScrollView root element to T.ScrollView with id 'control'
src/qml/ScrollView.qml
Add implicit dimension calculations
  • Introduced implicitWidth based on background size or content width plus padding and insets
  • Added implicitHeight similarly using background height or content height
src/qml/ScrollView.qml
Integrate Deepin custom scrollbars
  • Defined D.ScrollBar.vertical with dynamic positioning and activation tied to horizontal scrollbar state
  • Added D.ScrollBar.horizontal with layout adjusted to available width and activation linked to vertical scrollbar state
src/qml/ScrollView.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit fc9ec9e into linuxdeepin:master Oct 23, 2025
17 of 18 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Oct 23, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants