Skip to content

Conversation

@calsys456
Copy link
Collaborator

@calsys456 calsys456 commented Dec 24, 2025

These configuration fields is actually not used in anywhere, and will be removed by recent ddm refactor.

Summary by Sourcery

Remove unused user avatar configuration references from the greeter user model.

Enhancements:

  • Remove unused theme configuration access in UserModel constructor.
  • Drop unused disableAvatarsThreshold property and static accessor from UserModel interface.

These configuration fields is actually not used in anywhere, and will be
removed by recent ddm refactor.
@calsys456
Copy link
Collaborator Author

Paired with linuxdeepin/ddm#58

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes unused configuration references from the greeter UserModel, simplifying the API and eliminating dead code related to avatar configuration and theme faces directory.

Class diagram for UserModel before and after removing unused config references

classDiagram
    class UserModel_Before {
        <<QAbstractListModel>>
        %% Q_PROPERTY declarations
        int lastIndex
        QString lastUser
        int count
        int disableAvatarsThreshold
        bool containsAllUsers

        %% Methods
        +void setCurrentUserName(QString userName)
        +void updateUserLoginState(QString username, bool logined)
        +void clearUserLoginState()
        +static int disableAvatarsThreshold()
        +bool containsAllUsers() const
    }

    class UserModel_After {
        <<QAbstractListModel>>
        %% Q_PROPERTY declarations
        int lastIndex
        QString lastUser
        int count
        bool containsAllUsers

        %% Methods
        +void setCurrentUserName(QString userName) noexcept
        +void updateUserLoginState(QString username, bool logined)
        +void clearUserLoginState()
        +bool containsAllUsers() const
    }

    UserModel_Before <|-- UserModel_After
Loading

File-Level Changes

Change Details Files
Remove use of unused theme configuration fields in UserModel implementation.
  • Drop retrieval of Theme.FacesDir config value from the UserModel constructor since it is unused
  • Remove the disableAvatarsThreshold() static method implementation that just forwarded mainConfig.Theme.DisableAvatarsThreshold
src/greeter/usermodel.cpp
Simplify UserModel interface by removing an unused QML‑exposed property and its accessor.
  • Remove Q_PROPERTY disableAvatarsThreshold from the UserModel class so it is no longer exposed to QML
  • Delete the declaration of the static disableAvatarsThreshold() accessor from the UserModel public API
src/greeter/usermodel.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since disableAvatarsThreshold is removed as a Q_PROPERTY, double-check that no QML code still binds to it or expects it on UserModel, as that would now fail at runtime.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `disableAvatarsThreshold` is removed as a `Q_PROPERTY`, double-check that no QML code still binds to it or expects it on `UserModel`, as that would now fail at runtime.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zccrs zccrs merged commit dc9d33e into linuxdeepin:master Dec 24, 2025
9 of 11 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: calsys456, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants