-
Notifications
You must be signed in to change notification settings - Fork 34
fix: Remove unused config references #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These configuration fields is actually not used in anywhere, and will be removed by recent ddm refactor.
|
Paired with linuxdeepin/ddm#58 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves unused configuration references from the greeter UserModel, simplifying the API and eliminating dead code related to avatar configuration and theme faces directory. Class diagram for UserModel before and after removing unused config referencesclassDiagram
class UserModel_Before {
<<QAbstractListModel>>
%% Q_PROPERTY declarations
int lastIndex
QString lastUser
int count
int disableAvatarsThreshold
bool containsAllUsers
%% Methods
+void setCurrentUserName(QString userName)
+void updateUserLoginState(QString username, bool logined)
+void clearUserLoginState()
+static int disableAvatarsThreshold()
+bool containsAllUsers() const
}
class UserModel_After {
<<QAbstractListModel>>
%% Q_PROPERTY declarations
int lastIndex
QString lastUser
int count
bool containsAllUsers
%% Methods
+void setCurrentUserName(QString userName) noexcept
+void updateUserLoginState(QString username, bool logined)
+void clearUserLoginState()
+bool containsAllUsers() const
}
UserModel_Before <|-- UserModel_After
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since
disableAvatarsThresholdis removed as aQ_PROPERTY, double-check that no QML code still binds to it or expects it onUserModel, as that would now fail at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `disableAvatarsThreshold` is removed as a `Q_PROPERTY`, double-check that no QML code still binds to it or expects it on `UserModel`, as that would now fail at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: calsys456, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
These configuration fields is actually not used in anywhere, and will be removed by recent ddm refactor.
Summary by Sourcery
Remove unused user avatar configuration references from the greeter user model.
Enhancements: