Skip to content

fix: Remove unused config references #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zccrs merged 1 commit into from
Dec 24, 2025
Merged

fix: Remove unused config references #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/greeter/usermodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ UserModel::UserModel(QObject *parent)

// find out index of the last user
auto lastUserName = stateConfig.Last.User.get();
const auto &facesDir = mainConfig.Theme.FacesDir.get();

for (const auto &user : d->users) {
if (user->userName() == lastUserName) {
Expand Down Expand Up @@ -220,11 +219,6 @@ QVariant UserModel::data(const QModelIndex &index, int role) const
}
}

int UserModel::disableAvatarsThreshold()
{
return mainConfig.Theme.DisableAvatarsThreshold.get();
}

bool UserModel::containsAllUsers() const
{
return d->containsAllUsers;
Expand Down
2 changes: 0 additions & 2 deletions src/greeter/usermodel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@
Q_PROPERTY(int lastIndex READ lastIndex CONSTANT)
Q_PROPERTY(QString lastUser READ lastUser CONSTANT)
Q_PROPERTY(int count READ rowCount NOTIFY countChanged)
Q_PROPERTY(int disableAvatarsThreshold READ disableAvatarsThreshold CONSTANT)
Q_PROPERTY(bool containsAllUsers READ containsAllUsers CONSTANT)
QML_NAMED_ELEMENT(UserModel)

Check warning on line 42 in src/greeter/usermodel.h

View workflow job for this annotation

GitHub Actions / cppcheck 

There is an unknown macro here somewhere. Configuration is required. If QML_NAMED_ELEMENT is a macro then please configure it.
QML_SINGLETON

public:
Expand Down Expand Up @@ -79,7 +78,6 @@
void setCurrentUserName(const QString &userName) noexcept;
void updateUserLoginState(const QString &username, bool logined);
void clearUserLoginState();
[[nodiscard]] static int disableAvatarsThreshold();
[[nodiscard]] bool containsAllUsers() const;

Q_SIGNALS:
Expand Down