URL shortener should always be available

lib/suma/apps.rb

@@ -161,8 +161,7 @@ class AdminAPI < Suma::Service
   end
 
   UrlRedirects = Rack::Builder.new do
-    shortener = Suma::UrlShortener.new_shortener
-    run ::UrlShortener::RackApp.new(shortener)
+    run ::UrlShortener::RackApp.new(Suma::UrlShortener.shortener)
   end
 
   def self.emplace_dynamic_config

lib/suma/url_shortener.rb

@@ -36,7 +36,6 @@ def enabled? = !self.disabled
 
     # @return [UrlShortener]
     def shortener
-      return nil unless self.enabled?
       return @shortener ||= new_shortener
     end
 

spec/suma/url_shortener_spec.rb

@@ -3,10 +3,9 @@
 require "suma/url_shortener"
 
 RSpec.describe Suma::UrlShortener do
-  it "returns nil for the shortener if disabled", reset_configuration: Suma::UrlShortener do
+  it "returns the shortener (even if disabled)", reset_configuration: Suma::UrlShortener do
     described_class.disabled = true
-    expect(described_class.shortener).to be_nil
-    described_class.disabled = false
+    expect(described_class).to_not be_enabled
     expect(described_class.shortener).to be_a(UrlShortener)
   end
 end