Skip to content

Conversation

@Elbehery
Copy link
Contributor

What does this PR do?

This PR migrates unittest to pytest in tests/unit/providers/nvidia/test_eval.py.

Part of #2680

Supersedes #2791

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 25, 2025
@Elbehery Elbehery changed the title chore(test): migrate unit tests from unittest to pytest nvidia test eval chore(test): migrate unit tests from unittest to pytest nvidia test eval Aug 25, 2025
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch 8 times, most recently from be97e08 to 352d990 Compare August 29, 2025 00:18
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Oct 29, 2025
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch from 352d990 to b50d7c7 Compare November 3, 2025 19:42
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch from b50d7c7 to a219d9a Compare November 3, 2025 19:42
@Elbehery
Copy link
Contributor Author

Elbehery commented Nov 3, 2025

@leseb rebased 👍🏽

@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch 3 times, most recently from 85103e9 to 0851516 Compare November 3, 2025 20:40
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch from 0851516 to df18422 Compare November 4, 2025 00:04
@github-actions github-actions bot removed the stale label Nov 4, 2025
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch 2 times, most recently from d0f4997 to a9b8312 Compare November 4, 2025 00:47
@Elbehery Elbehery force-pushed the 20250717_migrate_unittest_pytest_nvidia_test_eval branch from a9b8312 to 5fe73c5 Compare November 4, 2025 09:21
@leseb leseb merged commit a6ddbae into llamastack:main Nov 4, 2025
17 checks passed
@Elbehery Elbehery deleted the 20250717_migrate_unittest_pytest_nvidia_test_eval branch November 4, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants