-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[WebAssembly] Combine any_true (setcc x, 0, eq) to not all_true #144741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
badumbatish
wants to merge
5
commits into
llvm:main
Choose a base branch
from
badumbatish:issue50142
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+193
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b1154b3
Precommit missed optimization test for #50142
badumbatish 5f5f740
Fix issue 50142 by adding AnyTrueCombine
badumbatish a093e7e
Use SDPatternMatching and remove truncate...
badumbatish 9a31f41
Precommit test to add 3 more any/all true patterns
badumbatish 0a086da
[WebAssembly] Add 3 more optimization for any/all
badumbatish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 | ||
; RUN: llc < %s -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+simd128 | FileCheck %s | ||
|
||
target triple = "wasm64" | ||
|
||
define i32 @all_true_16_i8(<16 x i8> %v) { | ||
; CHECK-LABEL: all_true_16_i8: | ||
; CHECK: .functype all_true_16_i8 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: i8x16.all_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp eq <16 x i8> %v, zeroinitializer | ||
%2 = bitcast <16 x i1> %1 to i16 | ||
%3 = icmp eq i16 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
define i32 @all_true_4_i32(<4 x i32> %v) { | ||
; CHECK-LABEL: all_true_4_i32: | ||
; CHECK: .functype all_true_4_i32 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: i32x4.all_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp eq <4 x i32> %v, zeroinitializer | ||
%2 = bitcast <4 x i1> %1 to i4 | ||
%3 = icmp eq i4 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
define i32 @all_true_8_i16(<8 x i16> %v) { | ||
; CHECK-LABEL: all_true_8_i16: | ||
; CHECK: .functype all_true_8_i16 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: i16x8.all_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp eq <8 x i16> %v, zeroinitializer | ||
%2 = bitcast <8 x i1> %1 to i8 | ||
%3 = icmp eq i8 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
define i32 @all_true_2_i64(<2 x i64> %v) { | ||
; CHECK-LABEL: all_true_2_i64: | ||
; CHECK: .functype all_true_2_i64 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: i64x2.all_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp eq <2 x i64> %v, zeroinitializer | ||
%2 = bitcast <2 x i1> %1 to i2 | ||
%3 = icmp eq i2 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
define i32 @all_true_4_i64(<4 x i64> %v) { | ||
; CHECK-LABEL: all_true_4_i64: | ||
; CHECK: .functype all_true_4_i64 (v128, v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: v128.const $push9=, 0, 0 | ||
; CHECK-NEXT: local.tee $push8=, $2=, $pop9 | ||
; CHECK-NEXT: i64x2.eq $push1=, $0, $pop8 | ||
; CHECK-NEXT: i64x2.eq $push0=, $1, $2 | ||
; CHECK-NEXT: i8x16.shuffle $push2=, $pop1, $pop0, 0, 1, 2, 3, 8, 9, 10, 11, 16, 17, 18, 19, 24, 25, 26, 27 | ||
; CHECK-NEXT: v128.any_true $push3=, $pop2 | ||
; CHECK-NEXT: i32.const $push4=, -1 | ||
; CHECK-NEXT: i32.xor $push5=, $pop3, $pop4 | ||
; CHECK-NEXT: i32.const $push6=, 1 | ||
; CHECK-NEXT: i32.and $push7=, $pop5, $pop6 | ||
; CHECK-NEXT: return $pop7 | ||
%1 = icmp eq <4 x i64> %v, zeroinitializer | ||
%2 = bitcast <4 x i1> %1 to i4 | ||
%3 = icmp eq i4 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
; setcc (iN (bitcast (set_cc (vNi1 X), 0, ne)), 0, ne | ||
; => any_true (set_cc (X), 0, ne) | ||
; => any_true (X) | ||
define i32 @any_true_1_4_i32(<4 x i32> %v) { | ||
; CHECK-LABEL: any_true_1_4_i32: | ||
; CHECK: .functype any_true_1_4_i32 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: v128.any_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp ne <4 x i32> %v, zeroinitializer | ||
%2 = bitcast <4 x i1> %1 to i4 | ||
%3 = icmp ne i4 %2, 0 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
; setcc (iN (bitcast (set_cc (vNi1 X), 0, eq)), -1, ne | ||
; => not all_true (set_cc (X), 0, eq) | ||
; => not all_true (set_cc (X), 0, eq) | ||
; => not not any_true (X) | ||
; => any_true (X) | ||
define i32 @any_true_2_4_i32(<4 x i32> %v) { | ||
; CHECK-LABEL: any_true_2_4_i32: | ||
; CHECK: .functype any_true_2_4_i32 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: v128.any_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp eq <4 x i32> %v, zeroinitializer | ||
%2 = bitcast <4 x i1> %1 to i4 | ||
%3 = icmp ne i4 %2, -1 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
||
; setcc (iN (bitcast (set_cc (vNi1 X), 0, ne)), -1, eq | ||
; => all_true (set_cc (X), 0, ne) | ||
; => all_true (X) | ||
define i32 @all_true_2_4_i32(<4 x i32> %v) { | ||
; CHECK-LABEL: all_true_2_4_i32: | ||
; CHECK: .functype all_true_2_4_i32 (v128) -> (i32) | ||
; CHECK-NEXT: # %bb.0: | ||
; CHECK-NEXT: i32x4.all_true $push0=, $0 | ||
; CHECK-NEXT: return $pop0 | ||
%1 = icmp ne <4 x i32> %v, zeroinitializer | ||
%2 = bitcast <4 x i1> %1 to i4 | ||
%3 = icmp eq i4 %2, -1 | ||
%conv3 = zext i1 %3 to i32 | ||
ret i32 %conv3 | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.