Skip to content

Conversation

gburgessiv
Copy link
Member

Direct use of list/dict is preferred, and something I learned about when I'd half-written this. Didn't realize I left these instances initially.

Direct use of `list`/`dict` is preferred, and something I learned about
when I'd half-written this. Didn't realize I left these instances
initially.
@gburgessiv gburgessiv requested a review from Copilot September 10, 2025 01:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes type annotations by replacing typing.Dict and typing.List with the built-in dict and list types, which are preferred in Python 3.9+. The change simplifies imports and aligns with current Python typing best practices.

  • Removed Dict and List imports from the typing module
  • Updated all type annotations to use lowercase dict and list instead of their typing counterparts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gburgessiv gburgessiv marked this pull request as ready for review September 10, 2025 01:41
@gburgessiv
Copy link
Member Author

(I assume postcommit review policies apply here, and this is really trivial + the tests pass, so...)

@gburgessiv gburgessiv merged commit c3670be into main Sep 10, 2025
1 check passed
@kbeyls
Copy link
Contributor

kbeyls commented Sep 10, 2025

looks fine to me, consider this postcommit reviewed :) (But I'm not a python expert, I'm trusting you and copilot that it's better not to use typing.Dict and typing.list, but instead use dict and list types.

@gburgessiv gburgessiv deleted the use-dict-list branch September 11, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants