Create Luau version of Luthier #171
Open
+474
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatxe
requested changes
Apr 23, 2025
Co-authored-by: ariel <[email protected]>
aatxe
approved these changes
Apr 23, 2025
aatxe
requested changes
Apr 23, 2025
Co-authored-by: ariel <[email protected]>
Nicell
commented
Apr 23, 2025
Nicell
commented
Apr 29, 2025
Comment on lines
+209
to
+216
| local libsPath = projectRelative("std", "libs") | ||
| local libs = fs.listdir(libsPath) | ||
|
|
||
| for _, lib in libs do | ||
| local aliasedPath = `@std/{lib.name}` | ||
| local libSrc = fs.readfiletostring(joinPath(libsPath, lib.name)) | ||
| fs.write(cpp, `\n \{"{aliasedPath}", R"({libSrc})"},\n`) | ||
| end |
There was a problem hiding this comment.
Doesn't support directories in std atm. No equivalent to os.walk makes this annoying, and it's unnecessary at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port Luthier to Luau. The only piece fully lacking is support for directories in
std. This also highlights that we're lackingos.walkandos.chdirequivalents, so I had to work around that.Closes #89