Skip to content

Update Button.cpp #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eugene-makeev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Button.cpp #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Button.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Button::Button(uint8_t pin, uint16_t debounce_ms)
: _pin(pin)
, _delay(debounce_ms)
, _state(HIGH)
, _debounce_state(_state)
, _ignore_until(0)
, _has_changed(false)
{
Expand All @@ -27,21 +28,20 @@ void Button::begin()

bool Button::read()
{
// ignore pin changes until after this delay time
if (_ignore_until > millis())
// monitor pin changes during debounce time
if (digitalRead(_pin) != _state)
{
// ignore any changes during this period
_state = !_state;
_ignore_until = millis() + _delay;
}

// pin has changed
else if (digitalRead(_pin) != _state)
// if no changes in debounce time, the button state stable, update value
else if (_ignore_until > millis())
{
_ignore_until = millis() + _delay;
_state = !_state;
_has_changed = true;
_has_changed = (_debounce_state != _state);
_debounce_state = _state;
}

return _state;
return _debounce_state;
}

// has the button been toggled from on -> off, or vice versa
Expand Down