Cleanup and refactor accountsdb index #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
9 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
thlorenz
approved these changes
Jun 26, 2025
GabrielePicco
approved these changes
Jun 27, 2025
Merged
bmuddha
force-pushed
the
bmuddha/refactor/accounts-db
branch
from
8fc7900 to
2bd3c68
Compare
thlorenz
added a commit
that referenced
this pull request
Jul 15, 2025
* dev: Cleanup and refactor accountsdb index (#419) chore: create dev branch
bmuddha
added a commit
that referenced
this pull request
Jul 15, 2025
Modify account layout in accounts database: 1. reuse slack space which is available in block allocation if possible, this avoids reallocation of accounts if the data field grows insignificantly. 2. track account owner change to avoid index checks in happy path depends on #419 closes #443 closes #441 <!-- greptile_comment --> ## Greptile Summary Major refactoring of AccountsDB storage and indexing system to optimize account data storage and improve performance through block space reuse and owner tracking. - Consolidated multiple LMDB environments into a single environment and introduced new `Table` abstraction in `magicblock-accounts-db/src/index/table.rs` for better database operation encapsulation - Modified account serialization in `magicblock-accounts-db/src/lib.rs` to reuse slack space in block allocations, reducing unnecessary reallocations for small data growth - Added owner change tracking to optimize index checks by skipping them in the happy path when owner hasn't changed - Improved LMDB iteration safety and efficiency in `magicblock-accounts-db/src/index/iterator.rs` by removing manual cursor management - Changed program account iteration behavior to return empty iterators instead of NotFound errors for better API consistency <!-- /greptile_comment -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Due to the use of a single environment instead of previously used 3, this is a breaking change, which requires running a migration script to fix up the index directory.
Greptile Summary
Major refactoring of the AccountsDB index system to improve performance and code organization by consolidating database environments and optimizing LMDB operations.
magicblock-accounts-db/src/index.rsTableabstraction inmagicblock-accounts-db/src/index/table.rsto encapsulate database operations cleanly