Skip to content
This repository was archived by the owner on Oct 30, 2021. It is now read-only.

[first cut/WIP] Left overs + cleaning up carmen-cache - #130

Closed
aarthykc wants to merge 1 commit into
masterfrom
clean-up
Closed

[first cut/WIP] Left overs + cleaning up carmen-cache#130
aarthykc wants to merge 1 commit into
masterfrom
clean-up

Conversation

@aarthykc

@aarthykc aarthykc commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Worked on cleaning carmen-cache this weekend:
We no longer use normalization-cache in carmen. Opening this PR to remove normalization cache along with simplifying carmen-cache that would involve:

  • using the write to disc pattern that we used for fuzzy-phrase, so as to be able to remove duplicative code in memory.cpp and rocksdb.cpp
  • (stretch goal) split NAN_METHOD() from the C++ code in order to be able to easily get C++ to talk to rust through C

cc @apendleton, @aaaandrea (since both of you have worked extensively on carmen-cache)

@apendleton

Copy link
Copy Markdown
Contributor

Stale; work on this proceeded instead in #135

@apendleton apendleton closed this Dec 10, 2018
@apendleton
apendleton deleted the clean-up branch December 10, 2018 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants