Skip to content
This repository was archived by the owner on Oct 30, 2021. It is now read-only.

[WIP] Cleanup and remove pass by value - #135

Merged
apendleton merged 5 commits into
pure-cppfrom
cleanup-and-remove-pass-by-value
Nov 28, 2018
Merged

[WIP] Cleanup and remove pass by value#135
apendleton merged 5 commits into
pure-cppfrom
cleanup-and-remove-pass-by-value

Conversation

@aarthykc

Copy link
Copy Markdown
Contributor

Starting this branch to track some of the work described in #132. This PR aims to

  • Remove normaization cache
  • Change the parameters that have been passed by value to const& to prevent copying so many times (apart from the ones that clang tidy changed anyway).

cc @apendleton (this isn't done yet)

@apendleton

Copy link
Copy Markdown
Contributor

We'll want to be careful about the functions that mutate the strings they accept as arguments. This is safe for pass by copy, but not for pass by reference -- we might end up mutating someone else's string. So we'll want to change them to const&, and then if they mutate anything, we'll want to make the copy explicit.

@apendleton
apendleton merged commit d1251b4 into pure-cpp Nov 28, 2018
@apendleton
apendleton deleted the cleanup-and-remove-pass-by-value branch November 28, 2018 18:41
@aarthykc aarthykc mentioned this pull request May 20, 2019
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants