QUAL: corrige avertissements Phan (nullable / variables non déclarées) dans massactions tâches#41
Merged
mapiolca merged 1 commit into2026-03-25-add-mass-actions-for-external-module-tasksfrom Mar 25, 2026
Conversation
b949081
into
2026-03-25-add-mass-actions-for-external-module-tasks
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
htdocs/projet/tasks.phpethtdocs/core/tpl/massactions_pre.tpl.php).Description
htdocs/projet/tasks.php(autour deL1068) on force l'argument 7 passé àload_fiche_titre()à être unestringnon-nullable via cast/coalescence:(string) ($massactionbutton ?? '').htdocs/core/tpl/massactions_pre.tpl.phpon remplace leisset()ambigu par une vérification d'objet robuste pour$taskstatic:if (!is_object($taskstatic ?? null)) { $taskstatic = null; }.$trackidet$modelmailenstringvia$trackid = (string) ($trackid ?? '');et$modelmail = (string) ($modelmail ?? '');pour éviter les variables non déclarées et assurer la compatibilité de type.Testing
php -l htdocs/projet/tasks.phpetphp -l htdocs/core/tpl/massactions_pre.tpl.php, les deux commandes ont retourné "No syntax errors detected".Codex Task