Skip to content

QUAL: corrige avertissements Phan (nullable / variables non déclarées) dans massactions tâches #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mapiolca merged 1 commit into from
Mar 25, 2026
Merged

QUAL: corrige avertissements Phan (nullable / variables non déclarées) dans massactions tâches #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions htdocs/core/tpl/massactions_pre.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,11 @@
@phan-var-force string $search_all
';

if (!isset($taskstatic) || !is_object($taskstatic)) {
if (!is_object($taskstatic ?? null)) {
$taskstatic = null;
}
if (!isset($trackid)) {
$trackid = '';
}
if (!isset($modelmail)) {
$modelmail = '';
}
$trackid = (string) ($trackid ?? '');
$modelmail = (string) ($modelmail ?? '');

if (!empty($sall) || !empty($search_all)) {
$search_all = empty($sall) ? $search_all : $sall;
Expand Down Expand Up @@ -329,7 +325,7 @@
$valuefieldprojrole .= '</div>';

$valuefieldtasksrole = '<div style="display: flex; align-items: center; justify-content: flex-end; padding-right: 150px">';
$valuefieldtasksrole .= $formcompany->selectTypeContact($taskstatic, '', 'tasksrole', 'internal', 'position', 0, 'widthcentpercentminusx maxwidth300', 0);

Check warning on line 328 in htdocs/core/tpl/massactions_pre.tpl.php

View workflow job for this annotation

GitHub Actions / phan / Run phan 

massactions_pre.tpl.php: PhanPossiblyUndeclaredGlobalVariable: Global variable $taskstatic is possibly undeclared
$valuefieldtasksrole .= '</div>';

$formquestion[] = array(
Expand Down
2 changes: 1 addition & 1 deletion htdocs/projet/tasks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@
$linktotasks .= dolGetButtonTitle($langs->trans('ViewGantt'), '', 'fa fa-stream imgforviewmode', DOL_URL_ROOT.'/projet/ganttview.php?id='.$object->id.'&withproject=1', '', 1, array('morecss' => 'reposition marginleftonly'));

//print_barre_liste($title, 0, $_SERVER["PHP_SELF"], '', $sortfield, $sortorder, $linktotasks, $num, $totalnboflines, 'generic', 0, '', '', 0, 1);
print load_fiche_titre($title, $linktotasks.' &nbsp; '.$linktocreatetask, 'projecttask', 0, '', '', $massactionbutton);
print load_fiche_titre($title, $linktotasks.' &nbsp; '.$linktocreatetask, 'projecttask', 0, '', '', (string) ($massactionbutton ?? ''));

$objecttmp = new Task($db);
$trackid = 'task'.$taskstatic->id;
Expand Down
Loading