Fix FAT TCS smart signal finding regression - #143
Merged
Conversation
masarray
marked this pull request as ready for review
August 13, 2026 02:26
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
ARSAS v1.6.22 can report
signal missingfor real TCS points when the customer FAT row contains only an exact data-object leaf such as.TCS1Fail/.TCS2Failwhile the discovered Siemens 6MD85 model exposes the full IEC 61850 path (for exampleADD/GGIO2.TCS1Fail.stVal). The score-based matcher introduced in PR #140 retained canonical LD/LN normalization but had no bounded recovery for a pathless imported object leaf.This is visible in the CCPP FAT evidence for AA1C1F13R4: exactly the two TCS rows are pathless while adjacent signals retain full ADD/GGIO2 references.
Fix
stValRegression coverage
.TCS1Failand.TCS2Failresolve uniquely to their full Siemens MMS referencesTCS1Failleaves in different logical nodes remain AMBIGUOUSTCS11FailandTCS1Healthyremain MISSINGField expectation
This should remove the false
FAT scope safety · 2 signal(s) were not foundcondition for the affected AA1C1F13R4 TCS rows without weakening FAT scope safety for genuinely uncertain mappings. Physical relay validation is still required before calling the field issue closed.