Fix Event Log value when legacy report sends CDC struct - #189
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Field Event Log export shows a raw IEC 61850 CDC structure in
Value, e.g.:Structure(3) {stVal=false, q=Quality{...}, t=BinaryTime(...)}while the monitored signal / IEC telegram is the Boolean
...stValleaf andPreviousValueis already scalar (False). This produces transitions such asFalse → Structure(...).Root cause
ARSAS currently pins an ARIEC61850 engine commit where generic SPS-style status DataObjects can still arrive through the report path as a rendered structure. The Event Log records the formatted display value, so the raw structure leaks into the CSV.
Fix
Iec61850ValueFormatterfor legacy values whose first named structure field is exactly BooleanstVal=true|false.True/False).stValstructures untouched, avoiding accidental collapse of measurement structures.Regression coverage
Tests use the same
Structure(3) {stVal=false, ...}payload observed in the supplied ARSAS Events CSV, cover both False and True, and verify a{mag=...}structure remains unchanged.The corresponding source fix is in ARIEC61850 PR #79. This ARSAS guard is intentionally retained for compatibility with older/pinned engine builds.