Skip to content

feat: add timeout comments to guardrail rule and provider entries in values.yaml#3612

Open
BearTS wants to merge 1 commit into
devfrom
05-20-chore_add_timeout_example_in_providers_yaml_file
Open

feat: add timeout comments to guardrail rule and provider entries in values.yaml#3612
BearTS wants to merge 1 commit into
devfrom
05-20-chore_add_timeout_example_in_providers_yaml_file

Conversation

@BearTS
Copy link
Copy Markdown
Contributor

@BearTS BearTS commented May 20, 2026

Summary

Adds inline documentation comments to the Bifrost Helm chart values for timeout configuration fields, clarifying the units and defaults for rule and provider execution timeouts.

Changes

  • Updated the timeout comment for guardrail rules to specify seconds as the unit and note the default value of 60 seconds (previously showed 1000, which was ambiguous in terms of units)
  • Added a timeout comment for guardrail providers to document the default value of 30 seconds

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Deploy or lint the Helm chart to confirm the values file renders correctly.

helm lint helm-charts/bifrost

Breaking changes

  • Yes
  • No

Related issues

Security considerations

None.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

Warning

Rate limit exceeded

@BearTS has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 25 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1072aadb-6bf4-4b47-b5f5-cc269b1c7444

📥 Commits

Reviewing files that changed from the base of the PR and between f4a7c96 and d7856f0.

📒 Files selected for processing (2)
  • docs/enterprise/guardrails.mdx
  • helm-charts/bifrost/values.yaml
📝 Walkthrough

Walkthrough

The Bedrock content-filter guardrails policy timeouts are updated in the Helm values configuration. The rule execution timeout default is reduced from 1000 to 60 seconds, and a provider execution timeout of 30 seconds is added for the policy.

Changes

Bedrock Guardrails Timeout Configuration

Layer / File(s) Summary
Bedrock guardrails timeout defaults
helm-charts/bifrost/values.yaml
Rule execution timeout is reduced to 60 seconds and provider execution timeout is set to 30 seconds for the Bedrock content-filter guardrails policy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

⏰✨ A rabbit hops through timeout lands,
Where Bedrock rules now have swift hands,
From a thousand down to sixty beats,
Faster filters, swifter feats,
Thirty seconds for the guard's last stand! 🛡️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding timeout comments to guardrail configurations in the Helm values.yaml file.
Description check ✅ Passed The description is complete and follows the template well, clearly explaining the documentation updates with proper sections and testing instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 05-20-chore_add_timeout_example_in_providers_yaml_file

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 20, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Confidence Score: 4/5

The Helm values change is safe; the enterprise guardrails doc has an intra-file contradiction introduced by this PR that needs resolution before merging.

The values.yaml comment changes are correct and harmless. However, docs/enterprise/guardrails.mdx now tells readers the unit is seconds while its own code examples still show values like 5000, 3000, and 2000 that only make sense as milliseconds — a direct contradiction introduced by this PR.

docs/enterprise/guardrails.mdx — the code examples need their timeout values updated to match the newly documented seconds unit.

Important Files Changed

Filename Overview
docs/enterprise/guardrails.mdx Description updated from "milliseconds" to "seconds (default: 60)", but code examples in the same file still use millisecond-scale values (e.g. timeout: 5000) that now directly contradict the updated unit.
helm-charts/bifrost/values.yaml Comment updated to specify "seconds" unit and default value (60 for rules, 30 for providers); no logic changes.

Comments Outside Diff (1)

  1. docs/enterprise/guardrails.mdx, line 207 (link)

    P1 Code examples still use millisecond-scale values after unit change

    The description on line 151 was updated to read "seconds (default: 60)", but the API and config examples in this same file still set timeout to values like 5000, 3000, and 2000 — which are only sensible as milliseconds. With the unit now documented as seconds, a user following these examples would configure an ~83-minute (5000 s) timeout. The examples at lines 231, 251, 276, 287, 298, 319, 328, and several others in this file all need to be updated to use realistic second-scale values (e.g., 5, 30, 60) to stay consistent with the new description.

Reviews (3): Last reviewed commit: "chore: add timeout example in providers ..." | Re-trigger Greptile

Comment thread helm-charts/bifrost/values.yaml
@BearTS BearTS force-pushed the 05-20-chore_add_timeout_example_in_providers_yaml_file branch from 0c421c0 to d7856f0 Compare May 20, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant