fix: gate Weaviate PVC creation on persistence.enabled

[BearTS]

Summary

The Weaviate PersistentVolumeClaim (PVC) in the Bifrost Helm chart was being created unconditionally whenever Weaviate was enabled and not using an external instance. This change gates PVC creation behind the persistence.enabled flag, preventing unnecessary PVC creation when persistence is not desired.

Changes

• Added .Values.vectorStore.weaviate.persistence.enabled as an additional condition to the PVC template, so the PVC is only created when persistence is explicitly enabled

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Deploy the Bifrost Helm chart with Weaviate enabled and vectorStore.weaviate.persistence.enabled set to false. Verify that no PVC is created. Then set it to true and confirm the PVC is created as expected.

helm template bifrost ./helm-charts/bifrost \
  --set vectorStore.enabled=true \
  --set vectorStore.type=weaviate \
  --set vectorStore.weaviate.enabled=true \
  --set vectorStore.weaviate.external.enabled=false \
  --set vectorStore.weaviate.persistence.enabled=false \
  | grep -i PersistentVolumeClaim

Expected: no PVC output when persistence.enabled=false.

Breaking changes

• Yes
• No

Related issues

Security considerations

None.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

Warning

Rate limit exceeded

@BearTS has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b3c7fe7e-d256-4a8e-8df4-c567b769fe8a

📥 Commits

Reviewing files that changed from the base of the PR and between 988cd9d and 029741c.

📒 Files selected for processing (1)

• helm-charts/bifrost/templates/weaviate-pvc.yaml

📝 Walkthrough

Walkthrough

The Helm template for Weaviate's PersistentVolumeClaim now includes an additional condition gate requiring vectorStore.weaviate.persistence.enabled to be true, alongside existing checks for vector store and Weaviate enablement. The PVC manifest itself remains unchanged.

Changes

Weaviate PVC Persistence Gate

Layer / File(s)	Summary
PVC persistence enablement condition helm-charts/bifrost/templates/weaviate-pvc.yaml	The Helm if condition at line 1 now gates PVC creation on vectorStore.weaviate.persistence.enabled, adding an explicit persistence enablement requirement to the existing vector store and Weaviate type checks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single line of Helm wisdom,
Where persistence guards the claim,
PVC waits for the right signal,
Before it stakes its name!
✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: gating Weaviate PVC creation on the persistence.enabled flag, which directly matches the core modification in the changeset.
Description check	✅ Passed	The description covers all key sections including summary, changes, type of change, affected areas, and testing instructions, though some checklist items remain unchecked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 05-20-chore_don_t_render_the_pvc_if_weavite_persistent_is_disabled

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[BearTS]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore: bump Bifrost Helm chart to 2.1.18 with feature flags, model catalog URL, and bug fixes #3623
• feat: add access_profile_id support to bifrost helm chart virtual key schema and helpers #3622
• fix: sort provider secrets and weaviate env vars alphabetically for deterministic Helm rendering #3621
• feat: add default password warnings for PostgreSQL and Redis in Helm chart NOTES.txt #3620
• fix: gate Weaviate PVC creation on persistence.enabled #3619 👈 (View in Graphite)
• fix: use REDISCLI_AUTH env var to avoid passing password via -a flag in Redis health checks #3618
• feat: add optional gRPC port to bifrost cluster deployment and service #3617
• feat: add timeout comments to guardrail rule and provider entries in values.yaml #3612
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — the fix correctly aligns PVC creation with the deployment template's existing persistence logic, and the default value of persistence.enabled: true preserves existing behavior.

The change is a single-line guard that matches the pattern already used in the Weaviate deployment template. The values.yaml default keeps persistence.enabled: true, so no existing deployments are affected. No logic regressions or edge cases are introduced.

No files require special attention.

Important Files Changed

Filename	Overview
helm-charts/bifrost/templates/weaviate-pvc.yaml	Adds persistence.enabled guard to PVC creation — correctly aligns with the deployment template which already uses emptyDir when persistence is disabled

_{Reviews (3): Last reviewed commit: "chore: don't render the pvc if weavite p..." | Re-trigger Greptile}