Skip to content

Conversation

rudiejd
Copy link
Contributor

@rudiejd rudiejd commented Jan 23, 2025

Summary of changes

Asana Ticket: N/A

Handle dynamo crash when scanning records


@firestack firestack requested review from a team and jzimbel-mbta and removed request for a team October 3, 2025 14:51
@firestack firestack added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Oct 3, 2025

opts
|> do_paginated_query(:scan, mod, [])
|> Enum.flat_map(fn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
I don't really like that neither this nor any of the other calls to do_paginated_query handle its potential error tuple return value, but it doesn't make a huge difference--the tuple will be surfaced when Enum.flat_map raises on it:

** (Protocol.UndefinedError) protocol Enumerable not implemented for {:error, "foo"} of type Tuple
<stacktrace snipped>

so I guess it's fine.
Would prefer to have do_paginated_query just raise directly if all of the call sites will end up raising anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants