Skip to content

fix(dynamo): handle dyamo crash #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(dynamo): handle dyamo crash #855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f17d7
fix(dynamo): handle dyamo crash
rudiejd Jan 23, 2025
7bc260d
fixup: format
rudiejd Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/api_accounts/lib/api_accounts/dynamo.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ defmodule ApiAccounts.Dynamo do
|> Enum.flat_map(fn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
I don't really like that neither this nor any of the other calls to do_paginated_query handle its potential error tuple return value, but it doesn't make a huge difference--the tuple will be surfaced when Enum.flat_map raises on it:

** (Protocol.UndefinedError) protocol Enumerable not implemented for {:error, "foo"} of type Tuple
<stacktrace snipped>

so I guess it's fine.
Would prefer to have do_paginated_query just raise directly if all of the call sites will end up raising anyway.

%Task{} = task -> Task.await(task)
results when is_list(results) -> results
_ -> []
end)
end

Expand All @@ -392,6 +393,9 @@ defmodule ApiAccounts.Dynamo do

{:error, reason} ->
{:error, reason}

_ ->
{:error, "unknown response"}
end
end

Expand Down
Loading