feat: optional MediaPipe subject scoring path - #182
Open
laurentketterle-hub wants to merge 2 commits into
Open
Conversation
…rgeos-bounties#34) - Cover all branches of score_subject_against_pose: JSON toy default, MediaPipe-unavailable fallback, no-person fallback, and success path. - Remove the dead use_mediapipe parameter and hoist the numpy import so the module passes ruff (F401/F821).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Optional MediaPipe subject score path
Adds the optional vision path for subject scoring while keeping the toy path as the offline default.
Changes
score_subject_against_posenow auto-detects image inputs (.jpg/.png/.webp...) and routes them through the optional MediaPipe landmark extraction.visionextra is not installed, extraction fails, or no person is detected, the function falls back to the synthetic toy vector so scoring still works offline (the toy path remains the default for JSON subjects).cli.py: thescorecommand documents image support and auto-extraction.extractortag (json-toy/mediapipe/toy-fallback) plusextraction_erroron fallback.Tests (acceptance: fallback tests)
tests/test_score_fallback.pycovers every branch: JSON toy default, MediaPipe-unavailable fallback, no-person fallback, successful extraction, and unknown-poseKeyError.All tests pass locally (
pytest: 47 passed, 5 skipped).