Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for local inference demo for LS 0.1 #163

Merged
merged 11 commits into from
Feb 6, 2025
Merged

update for local inference demo for LS 0.1 #163

merged 11 commits into from
Feb 6, 2025

Conversation

jeffxtang
Copy link
Contributor

What does this PR do?

To work with the updated LocalInferenceImpl here.

Closes # (issue)

Feature/Issue validation/testing/test plan

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration or test plan.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

Sorry, something went wrong.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 31, 2025
…ect model with together LS distro
@jeffxtang
Copy link
Contributor Author

jeffxtang commented Feb 1, 2025

With the updated iOS Swift SDK PR meta-llama/llama-stack-client-swift#18 and the meta-llama/llama-stack#911, iOS local inference works now.

Copy link
Contributor

@WuhanMonkey WuhanMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jeffxtang

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jeffxtang jeffxtang merged commit a6136af into main Feb 6, 2025
1 check passed
@jeffxtang jeffxtang deleted the ios_local branch February 6, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants