LocalInferenceImpl update for LS 0.1 #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
7 tasks
|
With the updated iOS Swift SDK PR meta-llama/llama-stack-client-swift#18 and this PR, iOS local inference works now - updated demo: meta-llama/llama-stack-apps#163 |
jeffxtang
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
ehhuang
as code owners
2 tasks
|
By the way what do you think about moving this completely into the Swift SDK? I don't think we should keep .swift files in this repository (this was an earlier decision) |
Yes definitely. Will move it after more careful tests with the SDK and demo and the setup steps - since submodules are involved in both this repo and the apps repo, and the steps to set up for local iOS inference can be much simplified. |
jeffxtang
added a commit
to meta-llama/llama-stack-apps
that referenced
this pull request
Feb 6, 2025
# What does this PR do? To work with the updated LocalInferenceImpl [here](meta-llama/llama-stack#911). Closes # (issue) ## Feature/Issue validation/testing/test plan Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced. Please also list any relevant details for your test configuration or test plan. - [ ] Test A Logs for Test A - [ ] Test B Logs for Test B ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/meta-llama/llama-stack-apps/blob/main/CONTRIBUTING.md#pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? - [ ] Did you write any new necessary tests? Thanks for contributing 🎉!
srikanthbachala20
pushed a commit
to srikanthbachala20/llama-stack
that referenced
this pull request
Feb 27, 2025
# What does this PR do? To work with the updated iOSCalendarAssistantWithLocalInf [here](https://github.com/meta-llama/llama-stack-apps/compare/ios_local). In short, provide a summary of what this PR does and why. Usually, the relevant context should be present in a linked issue. - [ ] Addresses issue (#issue) ## Test Plan Please describe: - tests you ran to verify your changes with result summaries. - provide instructions so it can be reproduced. ## Sources Please link relevant resources if necessary. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Ran pre-commit to handle lint / formatting issues. - [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md), Pull Request section? - [ ] Updated relevant documentation. - [ ] Wrote necessary unit or integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To work with the updated iOSCalendarAssistantWithLocalInf here.
In short, provide a summary of what this PR does and why. Usually, the relevant context should be present in a linked issue.
Test Plan
Please describe:
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?