Skip to content

build monarch_extension as extension-module (fixed) #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build monarch_extension as extension-module (fixed) #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72fc784
build monarch_extension as extension-module
colin2328 Oct 18, 2025
1a621ea
build monarch_extension as extension-module (2) (#1611)
shayne-fletcher Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controller/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ hyperactor_multiprocess = { version = "0.0.0", path = "../hyperactor_multiproces
monarch_messages = { version = "0.0.0", path = "../monarch_messages" }
nccl-sys = { path = "../nccl-sys" }
ndslice = { version = "0.0.0", path = "../ndslice" }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_json = { version = "1.0.140", features = ["alloc", "float_roundtrip", "raw_value", "unbounded_depth"] }
tokio = { version = "1.47.1", features = ["full", "test-util", "tracing"] }
Expand Down
2 changes: 1 addition & 1 deletion monarch_extension/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ monarch_tensor_worker = { version = "0.0.0", path = "../monarch_tensor_worker",
monarch_types = { version = "0.0.0", path = "../monarch_types" }
nccl-sys = { path = "../nccl-sys", optional = true }
ndslice = { version = "0.0.0", path = "../ndslice" }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
rdmaxcel-sys = { path = "../rdmaxcel-sys", optional = true }
serde = { version = "1.0.219", features = ["derive", "rc"] }
tokio = { version = "1.47.1", features = ["full", "test-util", "tracing"] }
Expand Down
2 changes: 1 addition & 1 deletion monarch_hyperactor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ndslice = { version = "0.0.0", path = "../ndslice" }
nix = { version = "0.30.1", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
once_cell = "1.21"
opentelemetry = "0.29"
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
pyo3-async-runtimes = { version = "0.24", features = ["attributes", "tokio-runtime"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_bytes = "0.11"
Expand Down
2 changes: 1 addition & 1 deletion monarch_messages/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ enum-as-inner = "0.6.0"
hyperactor = { version = "0.0.0", path = "../hyperactor" }
monarch_types = { version = "0.0.0", path = "../monarch_types" }
ndslice = { version = "0.0.0", path = "../ndslice" }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_bytes = "0.11"
thiserror = "2.0.12"
Expand Down
2 changes: 1 addition & 1 deletion monarch_rdma/extension/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ hyperactor = { version = "0.0.0", path = "../../hyperactor" }
hyperactor_mesh = { version = "0.0.0", path = "../../hyperactor_mesh" }
monarch_hyperactor = { version = "0.0.0", path = "../../monarch_hyperactor" }
monarch_rdma = { version = "0.0.0", path = ".." }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_json = { version = "1.0.140", features = ["alloc", "float_roundtrip", "raw_value", "unbounded_depth"] }
tracing = { version = "0.1.41", features = ["attributes", "valuable"] }
2 changes: 1 addition & 1 deletion monarch_tensor_worker/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ monarch_types = { version = "0.0.0", path = "../monarch_types" }
ndslice = { version = "0.0.0", path = "../ndslice" }
nix = { version = "0.30.1", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
parking_lot = { version = "0.12.1", features = ["send_guard"] }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_json = { version = "1.0.140", features = ["alloc", "float_roundtrip", "raw_value", "unbounded_depth"] }
sorted-vec = "0.8.3"
Expand Down
2 changes: 1 addition & 1 deletion monarch_types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ license = "BSD-3-Clause"
[dependencies]
derive_more = { version = "1.0.0", features = ["full"] }
hyperactor = { version = "0.0.0", path = "../hyperactor" }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
serde_bytes = "0.11"

Expand Down
4 changes: 4 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ def run(self):
with open("README.md", encoding="utf8") as f:
readme = f.read()

python_lib_dir = sysconfig.get_config_var("LIBDIR") # path to libpython3.10.so.1.0
rpath_flag = f"-C link-args=-Wl,-rpath,{python_lib_dir}"
os.environ["RUSTFLAGS"] = (os.environ.get("RUSTFLAGS", "") + " " + rpath_flag).strip()

rust_extensions = [
RustBin(
target="process_allocator",
Expand Down
2 changes: 1 addition & 1 deletion torch-sys-cuda/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cxx = "1.0.119"
derive_more = { version = "1.0.0", features = ["full"] }
fxhash = "0.2.1"
nccl-sys = { path = "../nccl-sys" }
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
serde = { version = "1.0.219", features = ["derive", "rc"] }
thiserror = "2.0.12"
torch-sys = { version = "0.0.0", path = "../torch-sys" }
Expand Down
2 changes: 1 addition & 1 deletion torch-sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ hyperactor = { version = "0.0.0", path = "../hyperactor" }
monarch_types = { version = "0.0.0", path = "../monarch_types" }
nccl-sys = { path = "../nccl-sys", optional = true }
paste = "1.0.14"
pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
pyo3 = { version = "0.24", features = ["anyhow", "extension-module", "multiple-pymethods", "py-clone"] }
regex = "1.11.1"
serde = { version = "1.0.219", features = ["derive", "rc"] }
thiserror = "2.0.12"
Expand Down