build monarch_extension as extension-module (fixed) #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D84956118
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84986921. |
shayne-fletcher
force-pushed
the
export-D84986921
branch
from
1b1d187 to
c21f750
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Oct 18, 2025
Summary: Pull Request resolved: meta-pytorch#1611 this is a patch of D84956118 where initialization of `rust_binding_args = ["--"] ` is changed to `rust_binding_args=[]`. `setup-tools-rust` inserts its own `--` to pass flags to `rustc` (along with `-Zthreads=...`). our extra `--` yields `-- -- -Zthreads=16 ...` so `-Zthreads=16` is misparsed as a positional input: ``` ... --crate-type cdylib -- -Zthreads=16 ... ^^^^ ^^ (1st) (2nd) ``` Differential Revision: D84986921
shayne-fletcher
force-pushed
the
export-D84986921
branch
from
c21f750 to
ab08436
Compare
Summary: Pull Request resolved: meta-pytorch#1611 the goal is to inject an rpath into the built `_rust_bindings.so`. we put `-C link-args=-Wl,-rpath,<dir>` into `RUST_FLAGS`. Differential Revision: D84986921
shayne-fletcher
force-pushed
the
export-D84986921
branch
from
ab08436 to
1a621ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
this is a patch of D84956118 where
rust_binding_args = ["--"]is removed.setup-tools-rustinserts its own--to pass flags torustc(along with-Zthreads=...). our extra--yields-- -- -Zthreads=16 ...so-Zthreads=16is misparsed as a positional input.Differential Revision: D84986921