Skip to content

[SER] GetAttributes(out udt) instead of templated return #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2025
Merged

[SER] GetAttributes(out udt) instead of templated return #7606

merged 8 commits into from
Jul 22, 2025
+209 −204

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Jul 1, 2025 

Old: T    HitObject::GetAttributes<T>()
New: void HitObject::GetAttributes(out udt)
  • remove HitObject::GetAttributes template code path from DeduceTemplateArgumentsForHLSL
  • cleanup intersection attribute diagnostic code path
  • adjust GetAttributes calls and expected AST, HLOps in tests (DXIL unaffected)

Closes #7534

This is a breaking change. Merge and release must be coordinated with:

@simoll
[SER] GetAttributes(out udt) instead of templated return
6100cc3 
Old: T    HitObject::GetAttributes<T>()
New: void HitObject::GetAttributes(out udt)

- remove HitObject::GetAttributes<T> code path from DeduceTemplateArgumentsForHLSL
- cleanup intersection attribute diagnostic code path
- adjust GetAttributes calls and expected AST, HLOps in tests (DXIL
  unaffected)

Closes microsoft#7534
tex3d
tex3d reviewed Jul 1, 2025
View reviewed changes
tex3d
tex3d reviewed Jul 2, 2025
View reviewed changes
@simoll simoll requested a review from tex3d July 7, 2025 06:08
@simoll simoll mentioned this pull request Jul 16, 2025
Open
@V-FEXrt V-FEXrt self-requested a review July 16, 2025 16:08
V-FEXrt
V-FEXrt reviewed Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@V-FEXrt V-FEXrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll leave Tex to approve since I'm very new to the codebase

tex3d
tex3d approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just some minor comments.

  • Sema &S instead of Sema *S
  • Avoid adding CheckNoInterpolationParams to Sema as method
  • Stale, incorrect comment

simoll and others added 2 commits July 17, 2025 06:44
@simoll @tex3d
Update tools/clang/lib/Sema/SemaHLSL.cpp
0dd2cb2 
Co-authored-by: Tex Riddell <[email protected]>
@simoll @tex3d
Apply suggestions from code review
267af66 
Sema* -> Sema&

Co-authored-by: Tex Riddell <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@simoll
Copy link
Contributor Author

simoll commented Jul 22, 2025

Good to merge. Can't do the merge myself, fyi

@V-FEXrt V-FEXrt enabled auto-merge (squash) July 22, 2025 16:07
@Icohedron
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@V-FEXrt V-FEXrt merged commit c78ed99 into microsoft:main Jul 22, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@V-FEXrt V-FEXrt V-FEXrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SER] Change HitObject::GetAttributes to use out param for attributes struct
4 participants
@simoll @Icohedron @tex3d @V-FEXrt