Update NativeModuleSample with 0.80.0 #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
1 similar comment
Contributor
Author
|
/azp run |
chiaramooney
reviewed
Aug 4, 2025
| "@react-native/eslint-config": "0.80.0", | ||
| "@types/jest": "^29.5.5", | ||
| "@types/react": "^19.0.0", | ||
| "@types/react": "19.0.0", |
Contributor
There was a problem hiding this comment.
I think we'll want to keep the '^' here. This will allow new minor versions of react to be installed.
Contributor
Author
There was a problem hiding this comment.
@chiaramooney made the change in latest commit.
chiaramooney
approved these changes
Aug 4, 2025
Contributor
|
LGTM, now we just need to test with preview 2 and stable then can merge this PR |
anupriya13
reviewed
Nov 3, 2025
anupriya13
reviewed
Nov 3, 2025
anupriya13
reviewed
Nov 3, 2025
anupriya13
reviewed
Nov 3, 2025
...leSample/cpp-lib/example/windows/NativeModuleSampleExample/NativeModuleSampleExample.vcxproj
Outdated
Show resolved
Hide resolved
anupriya13
reviewed
Nov 3, 2025
...leSample/cpp-lib/example/windows/NativeModuleSampleExample/NativeModuleSampleExample.vcxproj
Outdated
Show resolved
Hide resolved
anupriya13
reviewed
Nov 3, 2025
samples/NativeModuleSample/cpp-lib/windows/NativeModuleSample/NativeModuleSample.vcxproj
Outdated
Show resolved
Hide resolved
anupriya13
reviewed
Nov 3, 2025
samples/NativeModuleSample/cpp-lib/windows/NativeModuleSample/NativeModuleSample.vcxproj
Outdated
Show resolved
Hide resolved
anupriya13
approved these changes
Nov 3, 2025
anupriya13
changed the title
jonthysell
reviewed
Nov 3, 2025
Contributor
There was a problem hiding this comment.
These hardcoded PacakgeReferences should never have been added into this file. Who knows what conflicts it will cause.
Contributor
There was a problem hiding this comment.
lets take this up in a separate issue @HariniMalothu17 please create issue on the same!
jonthysell
reviewed
Nov 3, 2025
iamAbhi-916
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated NativeModuleSample for 0.80.0 release
Why
Update NativeModuleSample with 0.80.0-preview.1
Resolves [#14994]
Screenshots
Add any relevant screen captures here from before or after your changes.
Microsoft Reviewers: Open in CodeFlow