This repository was archived by the owner on Mar 21, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 116
enhance: RBAC Custom Privilege Group API #845
Merged
Merged
+476
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome @shaoting-huang! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉 |
/lgtm |
/cc @congqixia |
congqixia
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Signed-off-by: shaoting-huang <[email protected]>
31cd8df
to
eebda43
Compare
/kind enhancement |
congqixia
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 14, 2024
issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 14, 2024
issue: milvus-io/milvus#37031
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 14, 2024
issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 21, 2024
issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 21, 2024
issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
added a commit
to shaoting-huang/milvus-sdk-go
that referenced
this pull request
Nov 26, 2024
Loading
Loading status checks…
Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 26, 2024
cherry-pick from master: #845, #847 issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
review approved
ci-passed
auto merge needed label
kind/enhancement
New feature or request
lgtm
look good to me
size/L
Denotes a PR that changes 100-499 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#37031