[Feature]: RBAC customized and built-in privilege groups, and cleaner grant/revoke API #37031

shaoting-huang · 2024-10-21T11:24:32Z

Is there an existing issue for this?

I have searched the existing issues

What would you like to be added?

Support customized privilege groups so users can create, drop, list, add, or remove privileges on them.
Support 9 built-in privilege groups: ClusterReadOnly/ClusterReadWrite/ClusterAdmin、DatabaseReadOnly/DatabaseReadWrite/DatabaseAdmin、CollectionReadOnly/CollectionReadWrite/CollectionAdmin
Support Grant/Revoke V2 for cleaner API. Users do not need to pass ObjectType anymore.

Why is this needed?

Support RBAC custom privilege groups and built-in privilege groups to do batch grant/revoke.
Support Grant/Revoke V2 for cleaner API. Users do not need to pass ObjectType anymore.

Anything else?

No response

shaoting-huang · 2024-10-21T11:24:40Z

/assign

issue: #37031 --------- Signed-off-by: shaoting-huang <[email protected]>

issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io#37031 Signed-off-by: shaoting-huang <[email protected]>

Cherry-pick from master pr: #37087, #37558 issue: #37031 --------- Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io/milvus#37031 --------- Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io/milvus#37031

issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io/milvus#37031 issue: #2353 Signed-off-by: shaoting-huang <[email protected]>

issue: milvus-io/milvus#37031 issue: #2353 --------- Signed-off-by: shaoting-huang <[email protected]>

…38393) related issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

…ilvus-io#38393) related issue: milvus-io#37031 Signed-off-by: shaoting-huang <[email protected]>

…group (#38408) cherry-pick from master: #38393 related issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

cherry-pick from master: #2510 related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>

related: #37031 * built-in privilege group privileges in listPrivilegeGroups() should be the same as in milvus.yaml * collections granted by collection level built-in privilege group should be list in showCollections() Signed-off-by: shaoting-huang <[email protected]>

cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>

Related to milvus-io#31293 milvus-io#37031 This PR: - Add DescribeReplica API - Add unified RBAC v2 API names(AddPrivilegesToGroup, RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2) - Mark old ones deprecated Signed-off-by: Congqi Xia <[email protected]>

Related to #31293 #37031 This PR: - Add DescribeReplica API - Add unified RBAC v2 API names(AddPrivilegesToGroup, RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2) - Mark old ones deprecated Signed-off-by: Congqi Xia <[email protected]>

) Related to milvus-io#31293 milvus-io#37031 This PR: - Add DescribeReplica API - Add unified RBAC v2 API names(AddPrivilegesToGroup, RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2) - Mark old ones deprecated Signed-off-by: Congqi Xia <[email protected]>

Cherry pick from master pr: #40268 #40284 #40328 #40373 #40381 ------------------------------------------ #### fix: [GoSDK] Pass base64 passwd content instead of raw data (#40268) Related to #40261 Also add some options for create collection options and refine some behavior ------------------------------------------ #### fix: [GoSDK] Return role without grants (#40284) Related to #40274 Previousy DescribeRole returns only roles with grants, this PR add select role action to check role existence. Also added database properties related option ----------------------------------------- #### fix: [GoSDK] Pass only valid data for nullable column (#40328) Related to #40327 ----------------------------------------- #### enhance: [GoSDK] Add DescribeReplica API & sync rbac v2 (#40373) Related to #31293 #37031 This PR: - Add DescribeReplica API - Add unified RBAC v2 API names(AddPrivilegesToGroup, RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2) - Mark old ones deprecated ----------------------------------------- #### enhance: [GoSDK] support update ts caching policy(#40381) Related to #39093 This PR add update timestamp check and retry policy according to the design of the related issue ----------------------------------------- --------- Signed-off-by: Congqi Xia <[email protected]>

shaoting-huang added the kind/enhancement Issues or changes related to enhancement label Oct 21, 2024

sre-ci-robot assigned shaoting-huang Oct 21, 2024

This was referenced Oct 21, 2024

enhance: RBAC custom privilege group milvus-io/milvus-proto#330

Merged

enhance: Support custom privilege group for RBAC #37087

Merged

sre-ci-robot pushed a commit that referenced this issue Nov 9, 2024

enhance: Support custom privilege group for RBAC (#37087)

70605cf

issue: #37031 --------- Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Nov 9, 2024

enhance: RBAC custom privilege group ut coverage #37558

Merged

sre-ci-robot pushed a commit that referenced this issue Nov 9, 2024

enhance: RBAC custom privilege group ut coverage (#37558)

ff00a12

issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang added a commit to shaoting-huang/milvus that referenced this issue Nov 9, 2024

enhance: RBAC custom privilege group ut coverage (milvus-io#37558)

664e58b

issue: milvus-io#37031 Signed-off-by: shaoting-huang <[email protected]>

This was referenced Nov 9, 2024

enhance: [2.4] RBAC custom privilege group #37560

Merged

enhance: [2.4] RBAC custom privilege group milvus-io/milvus-proto#345

Merged

sre-ci-robot pushed a commit that referenced this issue Nov 11, 2024

enhance: [2.4] RBAC custom privilege group (#37560)

9e8b6ac

Cherry-pick from master pr: #37087, #37558 issue: #37031 --------- Signed-off-by: shaoting-huang <[email protected]>

This was referenced Nov 13, 2024

enhance: RBAC Custom Privilege Group API milvus-io/milvus-sdk-go#845

Merged

enhance: RBAC Custom Privilege Group API milvus-io/pymilvus#2342

Merged

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Nov 13, 2024

enhance: RBAC Custom Privilege Group API (#2342)

5ec0a60

issue: milvus-io/milvus#37031 --------- Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Nov 13, 2024

enhance: [2.4] RBAC Custom Privilege Group API milvus-io/pymilvus#2344

Merged

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Nov 13, 2024

enhance: [2.4] RBAC Custom Privilege Group API (#2344)

b490a0a

issue: milvus-io/milvus#37031 --------- Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit to milvus-io/milvus-sdk-go that referenced this issue Nov 14, 2024

enhance: RBAC Custom Privilege Group API (#845)

3d596ff

issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this issue Nov 14, 2024

enhance: RBAC Custom Privilege Group API (milvus-io#845)

5e5c127

issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Nov 14, 2024

enhance: [2.4] RBAC Custom Privilege Group API milvus-io/milvus-sdk-go#846

Closed

shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this issue Nov 14, 2024

enhance: RBAC Custom Privilege Group API (milvus-io#845)

111e5d3

issue: milvus-io/milvus#37031

shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this issue Nov 14, 2024

enhance: RBAC Custom Privilege Group API (milvus-io#845)

0cdd156

issue: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Nov 18, 2024

fix: [2.4] add privilege group orm (#2357)

416a8b4

issue: milvus-io/milvus#37031 issue: #2353 Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Nov 18, 2024

fix: add privilege group orm (#2356)

24cba21

issue: milvus-io/milvus#37031 issue: #2353 --------- Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Dec 12, 2024

enhance: add privilege group privilege into built-in privilege group #38393

Merged

sre-ci-robot pushed a commit that referenced this issue Dec 12, 2024

enhance: add privilege group privilege into built-in privilege group (#…

c2855a5

…38393) related issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang added a commit to shaoting-huang/milvus that referenced this issue Dec 12, 2024

enhance: add privilege group privilege into built-in privilege group (m…

59c9299

…ilvus-io#38393) related issue: milvus-io#37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Dec 12, 2024

enhance: [2.4] add privilege group privilege into built-in privilege group #38408

Merged

sre-ci-robot pushed a commit that referenced this issue Dec 12, 2024

enhance: [2.4] add privilege group privilege into built-in privilege …

19818c5

…group (#38408) cherry-pick from master: #38393 related issue: #37031 Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 24, 2024

fix: fix privilege typo (#2510)

a94b1a2

related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang added a commit to shaoting-huang/pymilvus that referenced this issue Dec 24, 2024

fix: fix privilege typo (milvus-io#2510)

0f0438f

related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Dec 24, 2024

fix: [2.4] fix privilege typo milvus-io/pymilvus#2511

Merged

shaoting-huang added a commit to shaoting-huang/pymilvus that referenced this issue Dec 24, 2024

fix: fix privilege typo (milvus-io#2510)

4cdaac6

related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

This was referenced Dec 24, 2024

fix: [2.5] fix privilege typo milvus-io/pymilvus#2512

Merged

fix: [2.4] fix privilege group list and list collections #38698

Merged

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 24, 2024

fix: [2.4] fix privilege typo (#2511)

abb6e2c

cherry-pick from master: #2510 related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 24, 2024

fix: [2.5] fix privilege typo (#2512)

292390d

cherry-pick from master: #2510 related: milvus-io/milvus#37031 Signed-off-by: shaoting-huang <[email protected]>

sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024

fix: [2.4] fix privilege group list and list collections (#38698)

ef6aae8

cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang mentioned this issue Dec 25, 2024

fix: [2.5] fix privilege group list and list collections #38738

Merged

sre-ci-robot pushed a commit that referenced this issue Dec 25, 2024

fix: [2.5] fix privilege group list and list collections (#38738)

a4901ef

cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>

shaoting-huang closed this as completed Jan 9, 2025

congqixia mentioned this issue Mar 5, 2025

enhance: [GoSDK] Add DescribeReplica API & sync rbac v2 #40373

Merged

congqixia mentioned this issue Mar 6, 2025

enhance: [2.5][GoSDK] sync milvusclient patches for 2.5.1 #40410

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature]: RBAC customized and built-in privilege groups, and cleaner grant/revoke API #37031

[Feature]: RBAC customized and built-in privilege groups, and cleaner grant/revoke API #37031

shaoting-huang commented Oct 21, 2024 •

edited

Loading

shaoting-huang commented Oct 21, 2024

[Feature]: RBAC customized and built-in privilege groups, and cleaner grant/revoke API #37031

[Feature]: RBAC customized and built-in privilege groups, and cleaner grant/revoke API #37031

Comments

shaoting-huang commented Oct 21, 2024 • edited Loading

Is there an existing issue for this?

What would you like to be added?

Why is this needed?

Anything else?

shaoting-huang commented Oct 21, 2024

shaoting-huang commented Oct 21, 2024 •

edited

Loading