Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Use param item formatter to avoid SetConfig to overlay (#39597) #39636

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

fix: Use param item formatter to avoid SetConfig to overlay (#39597)

7b07937
Select commit
Loading
Failed to load commit list.
Open

fix: [2.5] Use param item formatter to avoid SetConfig to overlay (#39597) #39636

fix: Use param item formatter to avoid SetConfig to overlay (#39597)
7b07937
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 5, 2025 in 0s

80.95% (target 77.00%)

View this Pull Request on Codecov

80.95% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (7fb91d1) to head (7b07937).

Files with missing lines Patch % Lines
pkg/util/paramtable/autoindex_param.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39636      +/-   ##
==========================================
- Coverage   80.97%   80.95%   -0.03%     
==========================================
  Files        1404     1404              
  Lines      198043   198043              
==========================================
- Hits       160361   160320      -41     
- Misses      32034    32061      +27     
- Partials     5648     5662      +14     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.48% <ø> (ø)
Go 82.91% <88.23%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
pkg/util/paramtable/autoindex_param.go 88.38% <88.23%> (ø)

... and 31 files with indirect coverage changes