Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] support update ts caching policy #40381

Merged

Conversation

congqixia
Copy link
Contributor

Related to #39093

This PR add update timestamp check and retry policy according to the
design of the related issue

Related to milvus-io#39093

This PR add update timestamp check and retry policy according to the
design of the related issue

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 5, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 5, 2025
@dosubot dosubot bot added the component/gosdk issues & PRs related to GoSDK package label Mar 5, 2025
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.51%. Comparing base (3db5656) to head (314051c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
client/milvusclient/write.go 74.28% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40381      +/-   ##
==========================================
- Coverage   80.53%   80.51%   -0.03%     
==========================================
  Files        1473     1473              
  Lines      207292   207314      +22     
==========================================
- Hits       166938   166911      -27     
- Misses      34286    34317      +31     
- Partials     6068     6086      +18     
Components Coverage Δ
Client 79.28% <85.71%> (+0.08%) ⬆️
Core 69.97% <ø> (ø)
Go 82.28% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
client/milvusclient/collection.go 91.73% <100.00%> (+0.06%) ⬆️
client/milvusclient/common.go 79.48% <100.00%> (+15.85%) ⬆️
client/milvusclient/write_options.go 65.86% <100.00%> (+0.27%) ⬆️
client/milvusclient/write.go 75.00% <74.28%> (+0.86%) ⬆️

... and 38 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 5, 2025
@sre-ci-robot sre-ci-robot merged commit 16bc2e8 into milvus-io:master Mar 5, 2025
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Mar 6, 2025
Related to milvus-io#39093

This PR add update timestamp check and retry policy according to the
design of the related issue

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Mar 6, 2025
Cherry pick from master
pr: #40268 #40284 #40328 #40373 #40381

------------------------------------------
#### fix: [GoSDK] Pass base64 passwd content instead of raw data
(#40268)

Related to #40261

Also add some options for create collection options and refine some
behavior

------------------------------------------
#### fix: [GoSDK] Return role without grants (#40284)

Related to #40274

Previousy DescribeRole returns only roles with grants, this PR add
select role action to check role existence.

Also added database properties related option

-----------------------------------------
#### fix: [GoSDK] Pass only valid data for nullable column (#40328)

Related to #40327

-----------------------------------------
#### enhance: [GoSDK] Add DescribeReplica API & sync rbac v2 (#40373)

Related to #31293 #37031

This PR:
- Add DescribeReplica API
- Add unified RBAC v2 API names(AddPrivilegesToGroup,
RemovePrivilegesFromGroup, GrantPrivilegeV2, RevokePrivilegeV2)
- Mark old ones deprecated

-----------------------------------------
#### enhance: [GoSDK] support update ts caching policy(#40381)

Related to #39093

This PR add update timestamp check and retry policy according to the
design of the related issue

-----------------------------------------

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/gosdk/support_cache_update_ts branch April 3, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed component/gosdk issues & PRs related to GoSDK package dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants