Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add lidar depth #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature/add lidar depth #9

wants to merge 5 commits into from

Conversation

AndyLi23
Copy link
Member

I did change how the params files are handled to reduce repetition, so changes might be breaking:

  • run_data = {**data, **data[run]} in data_params.py makes it possible to have params shared between runs AND params specific to runs (e.g. same robot topics, different timestamps for different runs).

  • The time params format was redundant, I changed it so all that is needed to set the start & end time is:

time:
    t0: ?
    tf: ?
    relative: ?
  • To toggle lidar globally or for each run: use_pointcloud: True or depth_source: 'pointcloud'

Example showing these changes:

runs: ['a', 'b']
run_env: "ROBOT"
dt: 0.16666666666666667

'a':
    time: 
        ...
    use_pointcloud: False
'b':
    time:
        ...
    use_pointcloud: True

pointcloud_data:
    path: ${BAGS_PATH}/${ROBOT}.bag
    topic: /lidar_points

Still needs official documentation & probably some cleanup, but wanted to start the merging process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant